Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: eliminate _you_ from N-API doc #21382
Conversation
Trott
added
doc
n-api
fast-track
labels
Jun 18, 2018
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
doc
dont-land-on-v4.x
n-api
labels
Jun 18, 2018
This comment has been minimized.
This comment has been minimized.
|
|
lpinca
approved these changes
Jun 18, 2018
richardlau
approved these changes
Jun 18, 2018
BridgeAR
approved these changes
Jun 18, 2018
BridgeAR
added
the
author ready
label
Jun 18, 2018
cjihrig
approved these changes
Jun 18, 2018
vsemozhetbyt
approved these changes
Jun 18, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 18, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed in 4970e2b |
Trott
closed this
Jun 18, 2018
targos
added a commit
that referenced
this pull request
Jun 19, 2018
This was referenced Jun 20, 2018
calebeby
added a commit
to Pigmice2733/scouting-frontend
that referenced
this pull request
Jun 20, 2018
This was referenced Jun 20, 2018
This was referenced Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Trott commentedJun 18, 2018
•
edited
The STYLE_GUIDE indicates that personal pronouns like "you" should be
avoided in reference documentation. Remove "you" from N-API doc.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes