Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upperf_hooks: simplify bootstrap milestones #21247
Conversation
jasnell
added some commits
Jun 3, 2018
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
C++
perf_hooks
labels
Jun 10, 2018
addaleax
approved these changes
Jun 14, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@nodejs/build OSX failure in CI... (nodejs/build#1345) |
This comment has been minimized.
This comment has been minimized.
TimothyGu
approved these changes
Jun 15, 2018
jasnell
added a commit
that referenced
this pull request
Jun 15, 2018
jasnell
added a commit
that referenced
this pull request
Jun 15, 2018
This comment has been minimized.
This comment has been minimized.
jasnell
closed this
Jun 15, 2018
targos
added a commit
that referenced
this pull request
Jun 16, 2018
targos
added a commit
that referenced
this pull request
Jun 16, 2018
This was referenced Jun 20, 2018
calebeby
added a commit
to Pigmice2733/scouting-frontend
that referenced
this pull request
Jun 20, 2018
This was referenced Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jasnell commentedJun 10, 2018
Several of the bootstrap milestones have not proven very useful. Remove the less useful ones while we're still in experimental.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes