Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: trim deprecation level definition text #21241
Conversation
Trott
requested a review
from nodejs/tsc
as a
code owner
Jun 10, 2018
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
doc
label
Jun 10, 2018
Trott
removed the request for review
from nodejs/tsc
Jun 10, 2018
lpinca
approved these changes
Jun 10, 2018
hiroppy
approved these changes
Jun 10, 2018
richardlau
approved these changes
Jun 10, 2018
COLLABORATOR_GUIDE.md
Outdated
| * *End-of-life* refers to APIs that have gone through Runtime Deprecation and | ||
| are no longer subject to the semantic versioning rules used by the project. | ||
| * *Documentation-Only Deprecation*: A deprecation notice is added to the API | ||
| API documentation but no functional changes are implemented in the code. By |
This comment has been minimized.
This comment has been minimized.
COLLABORATOR_GUIDE.md
Outdated
| are no longer subject to the semantic versioning rules used by the project. | ||
| * *Documentation-Only Deprecation*: A deprecation notice is added to the API | ||
| API documentation but no functional changes are implemented in the code. By | ||
| default there will be no deprecation warnings emitted for such deprecations at |
This comment has been minimized.
This comment has been minimized.
richardlau
Jun 10, 2018
Member
Since this is being trimmed, maybe drop the first occurrence deprecation?
COLLABORATOR_GUIDE.md
Outdated
| `NODE_PENDING_DEPRECATION=1` environment variable is set. | ||
|
|
||
| * *Runtime Deprecation*: A warning is emitted at runtime the first time that a | ||
| deprecated API is used. A command-line switch can be used to escalate such |
This comment has been minimized.
This comment has been minimized.
vsemozhetbyt
added
the
author ready
label
Jun 10, 2018
Trott
added some commits
Jun 10, 2018
TimothyGu
approved these changes
Jun 10, 2018
ryzokuken
approved these changes
Jun 10, 2018
jasnell
approved these changes
Jun 10, 2018
trivikr
approved these changes
Jun 11, 2018
starkwang
approved these changes
Jun 11, 2018
thefourtheye
approved these changes
Jun 11, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in 4c16693 |
Trott
closed this
Jun 13, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 13, 2018
targos
added a commit
that referenced
this pull request
Jun 13, 2018
dna2github
added a commit
to dna2fork/node
that referenced
this pull request
Jun 14, 2018
This was referenced Jun 20, 2018
calebeby
added a commit
to Pigmice2733/scouting-frontend
that referenced
this pull request
Jun 20, 2018
This was referenced Jun 20, 2018
This was referenced Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Trott commentedJun 10, 2018
Provide more concise explanations of the deprecation levels in
COLLABORATOR_GUIDE.md.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes