Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upsrc: use `%zx` in printf for size_t #21323
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
C++
label
Jun 13, 2018
richardlau
approved these changes
Jun 13, 2018
This comment has been minimized.
This comment has been minimized.
addaleax
added
the
fast-track
label
Jun 13, 2018
TimothyGu
approved these changes
Jun 14, 2018
trivikr
approved these changes
Jun 14, 2018
lpinca
approved these changes
Jun 14, 2018
ryzokuken
approved these changes
Jun 14, 2018
bzoz
approved these changes
Jun 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed in 6904759 |
addaleax
closed this
Jun 14, 2018
addaleax
added a commit
that referenced
this pull request
Jun 14, 2018
addaleax
reopened this
Jun 14, 2018
addaleax
deleted the
addaleax:windows-lx-zx-warning
branch
Jun 14, 2018
addaleax
closed this
Jun 14, 2018
targos
added a commit
that referenced
this pull request
Jun 14, 2018
This was referenced Jun 20, 2018
calebeby
added a commit
to Pigmice2733/scouting-frontend
that referenced
this pull request
Jun 20, 2018
This was referenced Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
addaleax commentedJun 13, 2018
This fixes a compiler warning on Windows.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes