Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updeps: Upgrade node-inspect to 1.11.5 #21055
Conversation
jkrems
requested a review
from nodejs/tsc
as a
code owner
May 31, 2018
jkrems
reviewed
May 31, 2018
| @@ -179,3 +179,4 @@ A simple bug fix: | |||
| ``` | |||
| fix: Handle multi-byte characters in search logic | |||
| ``` | |||
|
|
|||
This comment has been minimized.
This comment has been minimized.
jkrems
May 31, 2018
Author
Contributor
I assume this copied line triggers the TSC review request via CODEOWNERS?
This comment has been minimized.
This comment has been minimized.
|
To make |
Trott
approved these changes
May 31, 2018
|
Rubber-stamp LGTM if CI is green/yellow. |
jasnell
approved these changes
May 31, 2018
This comment has been minimized.
This comment has been minimized.
BridgeAR
added
the
author ready
label
Jun 1, 2018
bnoordhuis
approved these changes
Jun 1, 2018
jkrems
force-pushed the
jkrems:jk-node-inspect-1.11.4
branch
from
32ffa1e
to
adf43ee
Jun 1, 2018
jkrems
changed the title
deps: Upgrade node-inspect to 1.11.4
deps: Upgrade node-inspect to 1.11.5
Jun 1, 2018
This comment has been minimized.
This comment has been minimized.
|
Pulled in 1.11.5 to ensure that New CI: https://ci.nodejs.org/job/node-test-pull-request/15214/ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Yet another CI attempt: Edit: Ugh, mojave's hidden checkboxes bit me. |
This comment has been minimized.
This comment has been minimized.
|
Hah! This CI run did the trick. |
addaleax
added
the
inspector
label
Jun 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed in e11447a |
jkrems commentedMay 31, 2018
•
edited
Removes the prompt to report a bug when trying to launch the
debugger using a port that is already in use.
Changeset generated via:
Compare: nodejs/node-inspect@v1.11.3...v1.11.5
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes