Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: fix deprecation warning due to util.print #21265
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
test
label
Jun 11, 2018
cjihrig
approved these changes
Jun 11, 2018
tniessen
added
the
fast-track
label
Jun 11, 2018
This comment has been minimized.
This comment has been minimized.
|
Suggesting to fast-track this. |
BridgeAR
approved these changes
Jun 11, 2018
lpinca
approved these changes
Jun 11, 2018
lance
approved these changes
Jun 11, 2018
targos
approved these changes
Jun 11, 2018
trivikr
approved these changes
Jun 13, 2018
jasnell
approved these changes
Jun 14, 2018
This comment has been minimized.
This comment has been minimized.
|
Re-running CI due to flakes: https://ci.nodejs.org/job/node-test-pull-request-lite/879/ |
This comment has been minimized.
This comment has been minimized.
|
Landed in 0179e94. |
tniessen
closed this
Jun 15, 2018
tniessen
added a commit
that referenced
this pull request
Jun 15, 2018
targos
added a commit
that referenced
this pull request
Jun 16, 2018
This was referenced Jun 20, 2018
calebeby
added a commit
to Pigmice2733/scouting-frontend
that referenced
this pull request
Jun 20, 2018
This was referenced Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tniessen commentedJun 11, 2018
There should not be a reason to keep using the deprecated API here.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes