Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: add Michaël Zasso to Release team #21114
Conversation
targos
requested a review
from nodejs/tsc
as a
code owner
Jun 3, 2018
nodejs-github-bot
added
the
doc
label
Jun 3, 2018
addaleax
reviewed
Jun 3, 2018
| gpg --keyserver pool.sks-keyservers.net --recv-keys 71DCFD284A79C3B38668286BC97EC7A07EDE3FC1 | ||
| gpg --keyserver pool.sks-keyservers.net --recv-keys FD3A5288F042B6850C66B31F09FE44734EB7990E | ||
| gpg --keyserver pool.sks-keyservers.net --recv-keys C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 | ||
| gpg --keyserver pool.sks-keyservers.net --recv-keys 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 |
This comment was marked as resolved.
This comment was marked as resolved.
addaleax
Jun 3, 2018
Member
$ gpg --keyserver pool.sks-keyservers.net --recv-keys 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600
gpg: keyserver receive failed: No data
I don’t think this works yet? It might be my WiFi but it appears to work for other keys…
This comment has been minimized.
This comment has been minimized.
targos
Jun 3, 2018
Author
Member
I don't really know what I'm supposed to do? I went to http://pool.sks-keyservers.net/ and uploaded my public key.
This comment has been minimized.
This comment has been minimized.
addaleax
Jun 3, 2018
Member
Me neither :( There might be a tendency for @nodejs/crypto people to know?
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Jun 3, 2018
|
Seems to work now! |
richardlau
approved these changes
Jun 3, 2018
| @@ -584,20 +584,23 @@ Node.js releases are signed with one of the following GPG keys: | |||
| `FD3A5288F042B6850C66B31F09FE44734EB7990E` | |||
| * **Myles Borins** <myles.borins@gmail.com> | |||
| `C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8` | |||
| * **Michaël Zasso** <targos@protonmail.com> | |||
This comment has been minimized.
This comment has been minimized.
richardlau
Jun 3, 2018
Member
Are these supposed to be sorted alphabetically? (If so, you should be above Myles).
This comment has been minimized.
This comment has been minimized.
joyeecheung
approved these changes
Jun 3, 2018
TimothyGu
approved these changes
Jun 3, 2018
MylesBorins
added
the
fast-track
label
Jun 3, 2018
This comment has been minimized.
This comment has been minimized.
|
Adding fast track. Imported key and everything LGTM |
This comment has been minimized.
This comment has been minimized.
|
Possibly a stupid question (I'm not super familiar with the releaser onboarding process), does anything need to be done by the Build WG in conjunction with this PR? |
This comment has been minimized.
This comment has been minimized.
There's this section in the release repo: https://github.com/nodejs/Release/blob/master/GOVERNANCE.md#adding-new-releasers
|
gibfahn
approved these changes
Jun 3, 2018
lpinca
approved these changes
Jun 4, 2018
This comment has been minimized.
This comment has been minimized.
|
@maclover7 still to do includes
|
thefourtheye
approved these changes
Jun 5, 2018
cjihrig
approved these changes
Jun 5, 2018
This comment has been minimized.
This comment has been minimized.
|
Opened the issue in docker-node: nodejs/docker-node#779 |
This comment has been minimized.
This comment has been minimized.
|
Landed in 55e597d |
targos commentedJun 3, 2018
/cc @nodejs/release @nodejs/tsc