Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[11.x] use NativeModuleLoader to compile all the bootstrappers #25446
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
lib / src
label
Jan 11, 2019
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
This comment has been minimized.
This comment has been minimized.
|
I’ve squashed what I could, but only two of the reverts would actually cleanly cancel out with the previous commits. For the rest of this PR: Landed in 1805236...6528ce6 |
addaleax
closed this
Jan 14, 2019
Merged
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
This comment has been minimized.
This comment has been minimized.
|
just noticing this now... generally we don't treat staging branches as "holy"... we generally rebase out commits that shouldn't have landed for LTS edit: also apologies if I misunderstood, but it seems like we could have rebased out commits from staging rather than revert |
Merged
targos
added this to Closed PRs
in v11.x
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
joyeecheung commentedJan 11, 2019
•
edited
This is backported by first reverting out-of-order commits on v11.x-staging and then correcting the order of the commits for the changed files. See #24775 (comment)
cc @BridgeAR
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes