★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24770Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove duplicated noop function #24770

Closed
wants to merge 1 commit into from

Conversation

@ZYSzys
Copy link
Member

commented Dec 1, 2018

We have a noop function outside the if statement in the line 609 :)

node/lib/internal/bootstrap/node.js

Line 609 in eb6741b

function noop() {}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@addaleax
addaleax approved these changes Dec 1, 2018
View changes
@cjihrig
cjihrig approved these changes Dec 1, 2018
View changes
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 1, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19122/
@lpinca
lpinca approved these changes Dec 1, 2018
View changes
@BridgeAR
BridgeAR approved these changes Dec 1, 2018
View changes

@BridgeAR BridgeAR added the author ready label Dec 1, 2018

@starkwang
starkwang approved these changes Dec 3, 2018
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 4, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19171/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 4, 2018

Needs a rebase.

@Trott Trott removed the author ready label Dec 4, 2018

@ZYSzys
lib: remove duplicated noop function
Loading status checks…
8f99e33

@ZYSzys ZYSzys force-pushed the zys-contribs:bootstrap branch from e3338e8 to 8f99e33 Dec 4, 2018

@ZYSzys

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 4, 2018

@Trott Done, needs CI again ?
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 4, 2018

Re-based CI: https://ci.nodejs.org/job/node-test-pull-request/19176/
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 4, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19185/

@addaleax addaleax added lib / src author ready labels Dec 4, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 4, 2018
@ZYSzys @Trott
lib: remove duplicated noop function 
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
a89b873
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 4, 2018

Landed in a89b873`

@Trott Trott closed this Dec 4, 2018

@ZYSzys ZYSzys deleted the zys-contribs:bootstrap branch Dec 4, 2018

@joyeecheung joyeecheung referenced this pull request Dec 5, 2018
Closed
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@ZYSzys @BridgeAR
lib: remove duplicated noop function 
PR-URL: #24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
1b2373f
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@ZYSzys @BridgeAR
lib: remove duplicated noop function 
PR-URL: #24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
1ec4f8d
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
Merged
4 of 4 tasks complete
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 11, 2019
@ZYSzys @joyeecheung
lib: remove duplicated noop function 
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
Verified
This commit was signed with a verified signature.
joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D Learn about signing commits
373bbe7
addaleax added a commit that referenced this pull request Jan 14, 2019
@ZYSzys @addaleax
lib: remove duplicated noop function 
PR-URL: #24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>

Backport-PR-URL: #25446
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
87a58be
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@ZYSzys @refack
lib: remove duplicated noop function 
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
8c366ec
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@ZYSzys @BridgeAR
lib: remove duplicated noop function 
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>

Backport-PR-URL: nodejs#25446
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
ca7888d
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged

@BethGriggs BethGriggs added the dont-land-on-v10.x label Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax

@lpinca lpinca

@cjihrig cjihrig

@BridgeAR BridgeAR

@starkwang starkwang

Assignees
No one assigned
Labels
author ready dont-land-on-v10.x lib / src
Projects
None yet
Milestone
No milestone
9 participants
@ZYSzys @addaleax @Trott @danbev @lpinca @cjihrig @BridgeAR @starkwang @BethGriggs
You can’t perform that action at this time.