★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25090Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: improve inspectOptions validation #25090

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Reviewers

@jasnell jasnell

@antsmartian antsmartian

@lpinca lpinca

@targos targos

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready backported-to-v11.x console
Projects
  
Backported in v11.x
Milestone
No milestone
9 participants
@cjihrig @nodejs-github-bot @Trott @MylesBorins @targos @BridgeAR @jasnell @antsmartian @lpinca
@cjihrig
Copy link
Contributor

commented Dec 17, 2018

This commit adds stricter type checking to the inspectOptions option to the Console constructor.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the console label Dec 17, 2018

@targos

targos approved these changes Dec 17, 2018
View changes

@BridgeAR

BridgeAR approved these changes Dec 17, 2018
View changes

@lpinca

lpinca approved these changes Dec 17, 2018
View changes

@antsmartian

antsmartian approved these changes Dec 18, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 18, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19628/ ✔️

@Trott Trott added the author ready label Dec 18, 2018

@jasnell

jasnell approved these changes Dec 18, 2018
View changes

@cjihrig
console: improve inspectOptions validation 
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: #25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@cjihrig cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
Loading status checks…
bf36f07

@cjihrig cjihrig force-pushed the cjihrig:console branch from 575ef02 to bf36f07 Dec 19, 2018

@cjihrig cjihrig merged commit bf36f07 into nodejs:master Dec 19, 2018

@cjihrig cjihrig deleted the cjihrig:console branch Dec 19, 2018

@MylesBorins MylesBorins added the v11.x label Dec 25, 2018

@MylesBorins

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 25, 2018

This does not land cleanly on v11.x, would someone be willing to backport?

@MylesBorins MylesBorins added backport-requested-v11.x and removed v11.x labels Dec 25, 2018

@targos targos added this to Backport requested in v11.x Dec 28, 2018

@targos

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 1, 2019

Depends on #24978

BridgeAR added a commit that referenced this pull request Jan 10, 2019

@cjihrig @BridgeAR
console: improve inspectOptions validation 
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: #25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Unverified
The committer email address is not verified.
Learn about signing commits
Loading status checks…
049b24d

@BridgeAR BridgeAR added backported-to-v11.x and removed backport-requested-v11.x labels Jan 10, 2019

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 10, 2019

Backported directly to the staging branch due to recent console backports.

@BridgeAR BridgeAR moved this from Backport requested to Backported in v11.x Jan 10, 2019

addaleax added a commit that referenced this pull request Jan 14, 2019

@cjihrig @addaleax
console: improve inspectOptions validation 
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: #25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
272ddb1

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@cjihrig @refack
console: improve inspectOptions validation 
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: nodejs#25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
5614814

@BridgeAR BridgeAR referenced this pull request Jan 16, 2019

Merged

v11.7.0 proposal #25537

@MylesBorins MylesBorins referenced this pull request Jan 24, 2019

Merged

v11.8.0 proposal #25687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.