inspector: migrate process.binding to internalBinding #24931

BeniCheni · Dec 10, 2018

Refs #22160, this PR attempts to migrate process.binding('inspector') to internalBinding('inspector').

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines


      inspector: migrate process.binding to internalBinding

In places of process.binding('inspector'), migrate code to adapt
internalBinding.

Refs: #22160

joyeecheung · 2018-12-10T03:45:49Z

joyeecheung approved these changes

Dec 10, 2018

View changes

joyeecheung · Dec 10, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19374/ ✔️

BeniCheni · Dec 10, 2018

Hi reviewers,

Would like some mentoring on these observations.

Couldn't change these inline code w. process.binding('inspector'). If using internalBinding('inspector'), tests seemed to failed with ReferenceError: internalBinding is not defined:

lib/internal/bootstrap/node.js#L663

return `process.binding('inspector')...`

test/sequential/test-inspector-async-hook-setup-at-signal.js#L16

const script = `
  ...
  if (!process.binding('inspector').isEnabled()) return;

test/sequential/test-inspector-enabled.js#L9

const script = `
...
const inspector = process.binding('inspector');

Another observation is when seemingly inside a child process, I would also run into failed test if using internalBinding

test/sequential/test-inspector-async-call-stack-abort.js#L15

if (process.argv[2] === 'child') {
  ...
  const { registerAsyncHook } = process.binding('inspector');

P.S.: I've experimented w. // Flags: --expose-internals & const { internalBinding } = require('internal/test/binding');, but no luck.

devsnek · Dec 10, 2018

wrapForBreakOnFirstLine is concerning. i think we should be able to use the inspector api to set a breakpoint instead of modifying the code? cc @nodejs/v8-inspector

joyeecheung · Dec 10, 2018

@BeniCheni

For the test failures (ReferenceErrors), you'd need to obtain internalBinding via const { internalBinding } = require('internal/test/binding'); (which also needs --expose-internals)

For the wrapForBreakOnFirstLine, maybe instead of wrapping the source and pass it to callAndPauseOnStart, prepending a debugger; statement to the source would work, but I am not really sure

joyeecheung · Dec 10, 2018

BTW, do we even need to wrap that in wrapForBreakOnFirstLine? module._compile is already wrapping the source with callAndPauseOnStart if process._breakFirstLine is true

addaleax · 2018-12-10T14:12:12Z

addaleax approved these changes

Dec 10, 2018

View changes

joyeecheung · Dec 10, 2018

I implemented the part about -e --inspect-brk in #24946 since it involves quite of bit of changes in the inspector tests.

BridgeAR · 2018-12-12T14:56:04Z

BridgeAR approved these changes

Dec 12, 2018

View changes

danbev · Dec 13, 2018

Landed in 0500237.


      inspector: move process.binding to internalBinding

In places of process.binding('inspector'), migrate code to adapt
internalBinding.

PR-URL: #24931
Refs: #22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins · Dec 25, 2018

This doesn't land cleanly on v11.x, would someone be willing to make a backport?


      inspector: move process.binding to internalBinding

In places of process.binding('inspector'), migrate code to adapt
internalBinding.

PR-URL: nodejs#24931
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      inspector: move process.binding to internalBinding

In places of process.binding('inspector'), migrate code to adapt
internalBinding.

PR-URL: nodejs#24931
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      inspector: move process.binding to internalBinding

In places of process.binding('inspector'), migrate code to adapt
internalBinding.

PR-URL: #24931
Refs: #22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      inspector: move process.binding to internalBinding

In places of process.binding('inspector'), migrate code to adapt
internalBinding.

PR-URL: nodejs#24931
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      inspector: move process.binding to internalBinding

In places of process.binding('inspector'), migrate code to adapt
internalBinding.

PR-URL: #24931
Refs: #22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      inspector: move process.binding to internalBinding

In places of process.binding('inspector'), migrate code to adapt
internalBinding.

PR-URL: #24931
Refs: #22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Backport-PR-URL: #25446


      inspector: move process.binding to internalBinding

In places of process.binding('inspector'), migrate code to adapt
internalBinding.

PR-URL: nodejs#24931
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      inspector: move process.binding to internalBinding

In places of process.binding('inspector'), migrate code to adapt
internalBinding.

PR-URL: nodejs#24931
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      inspector: move process.binding to internalBinding

In places of process.binding('inspector'), migrate code to adapt
internalBinding.

PR-URL: nodejs#24931
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Backport-PR-URL: nodejs#25446

inspector: migrate process.binding to internalBinding
In places of process.binding('inspector'), migrate code to adapt internalBinding. Refs: #22160

Loading status checks…

9a30b1b

nodejs-github-bot added the lib / src label Dec 10, 2018

joyeecheung referenced this pull request Dec 10, 2018

lib: use debugger statement to break scripts in -e --inspect-brk #24946

Closed

2 of 2 tasks complete

BridgeAR added the author ready label Dec 12, 2018

danbev closed this Dec 13, 2018

danbev added a commit that referenced this pull request Dec 13, 2018

BeniCheni deleted the BeniCheni:inspector-internal-binding branch Dec 13, 2018

MylesBorins added the backport-requested-v11.x label Dec 25, 2018

targos added this to Backport requested in v11.x Dec 28, 2018

BeniCheni referenced this pull request Jan 6, 2019

Tracking Issue: process.binding to internalBinding #22160

Closed

32 of 33 tasks complete

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 9, 2019

BridgeAR referenced this pull request Jan 9, 2019

[v11.x] backport #25087, #24962, #24931 and #25006 #25405

Closed

4 of 4 tasks complete

BridgeAR added a commit that referenced this pull request Jan 10, 2019

BridgeAR added backported-to-v11.x and removed backport-requested-v11.x labels Jan 10, 2019

BridgeAR moved this from Backport requested to Backported in v11.x Jan 10, 2019

joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 11, 2019

addaleax added a commit that referenced this pull request Jan 14, 2019

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

BridgeAR referenced this pull request Jan 16, 2019

v11.7.0 proposal #25537

Merged

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019

MylesBorins referenced this pull request Jan 24, 2019

v11.8.0 proposal #25687

Merged

BethGriggs added the backport-requested-v10.x label Jul 3, 2019

nodejs/node

inspector: migrate process.binding to internalBinding #24931

inspector: migrate process.binding to internalBinding #24931

BeniCheni commented Dec 10, 2018 •

edited

nodejs-github-bot added the lib / src label Dec 10, 2018

This comment has been minimized.

joyeecheung commented Dec 10, 2018 •

edited by Trott

This comment has been minimized.

BeniCheni commented Dec 10, 2018 •

edited

This comment has been minimized.

devsnek commented Dec 10, 2018

This comment has been minimized.

joyeecheung commented Dec 10, 2018

This comment has been minimized.

joyeecheung commented Dec 10, 2018

This comment has been minimized.

joyeecheung commented Dec 10, 2018

BridgeAR added the author ready label Dec 12, 2018

This comment has been minimized.

danbev commented Dec 13, 2018

danbev closed this Dec 13, 2018

BeniCheni deleted the BeniCheni:inspector-internal-binding branch Dec 13, 2018

MylesBorins added the backport-requested-v11.x label Dec 25, 2018

This comment has been minimized.

MylesBorins commented Dec 25, 2018

targos added this to Backport requested in v11.x Dec 28, 2018

BridgeAR added backported-to-v11.x and removed backport-requested-v11.x labels Jan 10, 2019

BridgeAR moved this from Backport requested to Backported in v11.x Jan 10, 2019

BethGriggs added the backport-requested-v10.x label Jul 3, 2019

nodejs/node

Perfect your code

inspector: migrate process.binding to internalBinding #24931

Conversation

BeniCheni commented Dec 10, 2018 • edited

Checklist

nodejs-github-bot added the lib / src label Dec 10, 2018

This comment has been minimized.

joyeecheung commented Dec 10, 2018 • edited by Trott

This comment has been minimized.

BeniCheni commented Dec 10, 2018 • edited

This comment has been minimized.

devsnek commented Dec 10, 2018

This comment has been minimized.

joyeecheung commented Dec 10, 2018

This comment has been minimized.

joyeecheung commented Dec 10, 2018

This comment has been minimized.

joyeecheung commented Dec 10, 2018

BridgeAR added the author ready label Dec 12, 2018

This comment has been minimized.

danbev commented Dec 13, 2018

danbev closed this Dec 13, 2018

BeniCheni deleted the BeniCheni:inspector-internal-binding branch Dec 13, 2018

MylesBorins added the backport-requested-v11.x label Dec 25, 2018

This comment has been minimized.

MylesBorins commented Dec 25, 2018

targos added this to Backport requested in v11.x Dec 28, 2018

BridgeAR added backported-to-v11.x and removed backport-requested-v11.x labels Jan 10, 2019

BridgeAR moved this from Backport requested to Backported in v11.x Jan 10, 2019

BethGriggs added the backport-requested-v10.x label Jul 3, 2019

BeniCheni commented Dec 10, 2018 •

edited

joyeecheung commented Dec 10, 2018 •

edited by Trott

BeniCheni commented Dec 10, 2018 •

edited