★ wanayoo — archive 1999 https://github.com/utPLSQL/utPLSQL/pull/750Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issues with teamcity reporter #750

Merged
merged 3 commits into from Aug 16, 2018

Conversation

@jgebal
Copy link
Member

@jgebal jgebal commented Aug 11, 2018

  • the [ and ] were not escaped
  • the " was escaped though not needed
  • If total length of message inside the square brackets exceeds 4000 characters it's causing teamcity to report success for a test failed
    Resolves #747
- the `[` and `]` were not escaped
- the `"` was escaped though not needed
- If total length of message inside the square brackets exceeds 4000 characters it's causing teamcity to report success for a test failed
Resolves #747
@jgebal jgebal added this to the v3.1.3 milestone Aug 11, 2018
@Pazus
Pazus approved these changes Aug 12, 2018
@jgebal
Copy link
Member Author

@jgebal jgebal commented Aug 12, 2018

Need to add one more test fir long outputs. If output is long I cut it and the message can be misleadimg as it doesn't say it's trimmed.

@jgebal jgebal added the bugfix label Aug 16, 2018
@jgebal jgebal merged commit eaa02e0 into develop Aug 16, 2018
4 checks passed
4 checks passed
SonarCloud Code Quality check passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 94.272%
Details
@jgebal jgebal deleted the bugfix/teamcity_reporter_escape_codes branch Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.