Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
TeamCity reporter not properly working with cursor comparison #747
Comments
|
It must be a bug. |
|
Did some more investigation on that.
I think there is a better place to actualy scape the brakets but it was just trying stufs. Can you give it a try? |
|
Great stuff. You did sll thr hard work of investigation. |
|
@PabloTorresAnaya I'll install TeamCity Docker image and see if I can get utPLSQL build running there. |
- the `[` and `]` were not escaped - the `"` was escaped though not needed - If total length of message inside the square brackets exceeds 4000 characters it's causing teamcity to report success for a test failed Resolves #747
|
yes, as I mention the not-escaped character were causing the issue in the end, the lenght was a dead-end clue. From my point of view, escaping the "[" ,"]" characters should be suficient. |
|
I tested on Teamcity locally (docker) with local database.
|
|
Morning, If i have time i can try to reproduce the error but i think the issue still there. So, I agree, there are 2 issues. |
Background:
Doing a cursor comparison like this one:
If the test fail on the teamcity report we will have something like:
##teamcity[testFailed timestamp='2018-08-03T10:11:14.221+0200' details='Actual: |r ....... ' Name='name' ]
Inside the details the xml structure of the actual cursor and the expected cursor can be found.
Issue
Teamcity is no able to detect the testFailed. So teamcity report it as green (success) when it failed, it shall be red.
Posible problem
I opened the build log of team city and the line with all XML structure was infact in diferent lines with line breaks (every 4000 characters). So i think the problem is that the output line of the Teamcity reporter was to big and teamcity was not able to parse it.
Posible fix
Trim the details string to 2500 or 3000 characters so the ##teamcity is less than 4000.