★ wanayoo — archive 1999 https://github.com/pre-commit/pre-commit/pull/1561Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show skipped messages in verbose mode #1561

Closed

Conversation

@peterjc
Copy link

@peterjc peterjc commented Aug 15, 2020

This is an alternative proposal to the --quiet or -q option proposed on #823, requiring no configuration changes.

My proposal is that the "Skipped" hook messages are only shown in verbose mode.

(This is a proof of principle, at least 20 tests need fixing - either to adjust the expected output, and/or explicitly set verbose mode)

@peterjc peterjc marked this pull request as draft Aug 15, 2020
@peterjc peterjc mentioned this pull request Aug 16, 2020
1 of 4 tasks complete
@asottile
Copy link
Member

@asottile asottile commented Aug 22, 2020

the things that are skipped are important information that shouldn't be hidden by default

@asottile asottile closed this Aug 22, 2020
@peterjc
Copy link
Author

@peterjc peterjc commented Aug 22, 2020

I would have been pleasantly surprised if you'd liked this idea - after all, the defaults presumably reflect your preferences on which messages should be shown. OK, so any efforts on my part are better directed to #823 (quiet mode). Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.