Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
WIP: Add quiet mode to pre-commit run #1218
Conversation
|
first off, thanks for working on this I don't think I can accept this in its current state, there's a ton of complexity added in this patch (for a feature I'll never really use) that I'm not comfortable with. Also the use of inheritance when a function would do seems not a good idea let me know if you'd like a more in depth review but I think this feature might just be too complex to implement (and especially in one go) |
|
@asottile I tried write this with So my decision is just inject new Lets going to simplify the solution (if we will can without increase complexity)! |
Add
--quietflag otpre-commit runto show only failing hook's messages.Fix #823
TODO:
--quietflag topre-commit runPRE_COMMIT_QUIET=0|1|false|truewhich allow users to enable quiet mode by default in their PC--output-mode=[normal|quiet]topre-commit installcommand