Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisessrc: don't abort on EIO when restoring tty #28490
+4
−1
Conversation
nodejs-github-bot
added
the
C++
label
Jul 1, 2019
bnoordhuis
referenced this pull request
Jul 1, 2019
Closed
CHECK failure in ResetStdio on >=12.5.0 #28479
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
Jul 1, 2019
This comment has been minimized.
This comment has been minimized.
|
Do we want to fast track? I'm going to prepare a release tomorrow |
gireeshpunathil
approved these changes
Jul 1, 2019
cjihrig
approved these changes
Jul 1, 2019
addaleax
added
the
fast-track
label
Jul 1, 2019
addaleax
approved these changes
Jul 1, 2019
addaleax
added
tty
author ready
labels
Jul 1, 2019
This comment has been minimized.
This comment has been minimized.
devsnek
approved these changes
Jul 1, 2019
This comment has been minimized.
This comment has been minimized.
|
landed in 1095635 |
devsnek
closed this
Jul 2, 2019
devsnek
added a commit
that referenced
this pull request
Jul 2, 2019
targos
added a commit
that referenced
this pull request
Jul 2, 2019
targos
added a commit
that referenced
this pull request
Jul 2, 2019
targos
added a commit
that referenced
this pull request
Jul 2, 2019
targos
added a commit
that referenced
this pull request
Jul 2, 2019
targos
added a commit
that referenced
this pull request
Jul 2, 2019
targos
added a commit
that referenced
this pull request
Jul 3, 2019
This was referenced Jul 3, 2019
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Jul 4, 2019
bnoordhuis
referenced this pull request
Jul 4, 2019
Closed
build: block SIGTTOU before calling tcsetattr() #28535
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Jul 4, 2019
pull bot
pushed a commit
to Mattlk13/node
that referenced
this pull request
Jul 6, 2019
targos
added a commit
that referenced
this pull request
Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bnoordhuis commentedJul 1, 2019
EIO has been observed to be returned by the Linux kernel under some
circumstances. Reading through drivers/tty/tty_io*.c, it seems to
indicate the tty went away. Of course none of this is documented.
Fixes: #28479