Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: add gengjiawen to collaborators #28322
Conversation
nodejs-github-bot
added
the
doc
label
Jun 20, 2019
gengjiawen
requested review from
gireeshpunathil and
mcollina
Jun 20, 2019
gireeshpunathil
approved these changes
Jun 20, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ZYSzys
approved these changes
Jun 20, 2019
gireeshpunathil
added
the
author ready
label
Jun 20, 2019
joyeecheung
approved these changes
Jun 20, 2019
gengjiawen
added a commit
that referenced
this pull request
Jun 20, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed as b0f7581 |
gengjiawen
closed this
Jun 20, 2019
targos
added a commit
that referenced
this pull request
Jul 2, 2019
targos
added a commit
that referenced
this pull request
Jul 2, 2019
targos
added a commit
that referenced
this pull request
Jul 2, 2019
targos
added a commit
that referenced
this pull request
Jul 3, 2019
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
gengjiawen commentedJun 20, 2019
•
edited
Add myself to collaborators
Fixes: #27731
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes