Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbuild: re-enable custom V8 snapshot by default #28181
+6
−7
Conversation
joyeecheung
added some commits
Jun 11, 2019
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Jun 11, 2019
•
|
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
added
build
tools
labels
Jun 11, 2019
targos
approved these changes
Jun 11, 2019
devsnek
approved these changes
Jun 11, 2019
This comment has been minimized.
This comment has been minimized.
|
pummel/test-hash-seed CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/7398/ |
addaleax
approved these changes
Jun 11, 2019
joyeecheung
added
the
author ready
label
Jun 11, 2019
refack
approved these changes
Jun 11, 2019
bnoordhuis
approved these changes
Jun 12, 2019
joyeecheung
referenced this pull request
Jun 12, 2019
Open
git-node: check if there are duplicates in Refs and PR-URL #350
This comment has been minimized.
This comment has been minimized.
|
@bnoordhuis Oops, it's supposed to be #17058 thanks for catching that. |
BridgeAR
approved these changes
Jun 12, 2019
jasnell
approved these changes
Jun 14, 2019
Trott
approved these changes
Jun 17, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in 28d3f19 |
joyeecheung
closed this
Jun 17, 2019
joyeecheung
added a commit
that referenced
this pull request
Jun 17, 2019
joyeecheung
added a commit
that referenced
this pull request
Jun 17, 2019
BridgeAR
added a commit
that referenced
this pull request
Jun 17, 2019
BridgeAR
added a commit
that referenced
this pull request
Jun 17, 2019
targos
added a commit
that referenced
this pull request
Jun 18, 2019
targos
added a commit
that referenced
this pull request
Jun 18, 2019
BridgeAR
added
the
notable-change
label
Jun 20, 2019
BridgeAR
added a commit
that referenced
this pull request
Jun 26, 2019
BridgeAR
added a commit
that referenced
this pull request
Jun 26, 2019
BridgeAR
added a commit
that referenced
this pull request
Jun 26, 2019
BridgeAR
added a commit
that referenced
this pull request
Jun 27, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jun 27, 2019
styfle
referenced this pull request
Jun 27, 2019
Open
RFC: speeding up Node.js startup using V8 snapshot #17058
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
joyeecheung commentedJun 11, 2019
•
edited
tools: assert that the snapshot can be rehashed in node_mksnapshot
build: turn on custom V8 snapshot by default
This patch re-enables custom V8 snapshot integration. Also renames
the experimental configure switch from
--with-node-snapshotto
--without-node-snapshotto be consistent with--without-snapshotwhich is used for the default V8 snapshot.
Refs: #27365
Refs: #17058
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes