Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesutil: special handle `maxArrayLength` while grouping arrays #28059
Conversation
BridgeAR
referenced this pull request
Jun 4, 2019
Closed
util.inspect cuts off strings too early #27690
targos
approved these changes
Jun 4, 2019
This comment has been minimized.
This comment has been minimized.
|
definitely looking better, but i'm still not sure why we can't do this:
|
This comment has been minimized.
This comment has been minimized.
|
@devsnek I have a follow up PR ready that increases the columns for arrays with short entries further. That comes relatively near to what you suggest. |
This comment was marked as outdated.
This comment was marked as outdated.
BridgeAR
added
author ready
util
labels
Jun 5, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Jun 9, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in 0059b87 |
antsmartian
closed this
Jun 9, 2019
antsmartian
added a commit
that referenced
this pull request
Jun 9, 2019
BridgeAR
added a commit
that referenced
this pull request
Jun 17, 2019
BridgeAR
added a commit
that referenced
this pull request
Jun 26, 2019
BridgeAR
added a commit
that referenced
this pull request
Jun 26, 2019
BridgeAR
added a commit
that referenced
this pull request
Jun 26, 2019
BridgeAR
added a commit
that referenced
this pull request
Jun 27, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BridgeAR commentedJun 4, 2019
This makes sure that large arrays with lots of small entries ignore
the
... n more item(s)part since it often resulted in output thatusers did not expect.
Now that part is printed on a separate line to indicate extra entries.
Now:

Before:
Refs: #27690
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes