★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24050Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct async_hooks sample outputs #24050

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

Assignees
No one assigned
Labels
async_hooks doc
Projects
None yet
Milestone
No milestone
4 participants
@Flarna @vsemozhetbyt @jasnell @nodejs-github-bot
@Flarna
Copy link
Member

Flarna commented Nov 2, 2018

Correct the output of async_hooks samples

  • TIMERWRAP has been removed in #20894
  • console.log() doesn't issue TTYWRAP nor SIGNALWRAP

I don't know which PR caused that console.log() is no longer using
TTYWRAP and SIGNALWRAP; I think it was between 8.4.0 and 8.5.0.

Ref: #20894

Checklist
@Flarna
doc: correct async_hooks sample outputs 
Correct the output of async_hooks samples
* `TIMERWRAP` has been removed in #20894
* `console.log()` doesn't issue `TTYWRAP` nor `SIGNALWRAP`

I don't know which PR caused that `console.log()` is no longer using
`TTYWRAP` and `SIGNALWRAP`; I think it was between 8.4.0 and 8.5.0.

Ref: #20894
Loading status checks…
b2f761c

@nodejs-github-bot nodejs-github-bot added async_hooks doc labels Nov 2, 2018

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Nov 2, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1464/
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Nov 6, 2018

сс @nodejs/async_hooks
@jasnell

jasnell approved these changes Nov 10, 2018
View changes

vsemozhetbyt added a commit that referenced this pull request Nov 11, 2018

@Flarna @vsemozhetbyt
doc: correct async_hooks sample outputs 
Correct the output of async_hooks samples
* `TIMERWRAP` has been removed in #20894
* `console.log()` doesn't issue `TTYWRAP` nor `SIGNALWRAP`

I don't know which PR caused that `console.log()` is no longer using
`TTYWRAP` and `SIGNALWRAP`; I think it was between 8.4.0 and 8.5.0.

PR-URL: #24050
Refs: #20894
Reviewed-By: James M Snell <jasnell@gmail.com>
Loading status checks…
7cf9a33
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Nov 11, 2018

Landed in 7cf9a33
Thank you!

@vsemozhetbyt vsemozhetbyt closed this Nov 11, 2018

@Flarna Flarna deleted the Flarna:doc_async-hooks branch Nov 11, 2018

BridgeAR added a commit that referenced this pull request Nov 14, 2018

@Flarna @BridgeAR
doc: correct async_hooks sample outputs 
Correct the output of async_hooks samples
* `TIMERWRAP` has been removed in #20894
* `console.log()` doesn't issue `TTYWRAP` nor `SIGNALWRAP`

I don't know which PR caused that `console.log()` is no longer using
`TTYWRAP` and `SIGNALWRAP`; I think it was between 8.4.0 and 8.5.0.

PR-URL: #24050
Refs: #20894
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
82c64d0

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018

@Flarna @kiyomizumia
doc: correct async_hooks sample outputs 
Correct the output of async_hooks samples
* `TIMERWRAP` has been removed in nodejs#20894
* `console.log()` doesn't issue `TTYWRAP` nor `SIGNALWRAP`

I don't know which PR caused that `console.log()` is no longer using
`TTYWRAP` and `SIGNALWRAP`; I think it was between 8.4.0 and 8.5.0.

PR-URL: nodejs#24050
Refs: nodejs#20894
Reviewed-By: James M Snell <jasnell@gmail.com>
4d4ef2f

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

codebytere added a commit that referenced this pull request Dec 14, 2018

@Flarna @codebytere
doc: correct async_hooks sample outputs 
Correct the output of async_hooks samples
* `TIMERWRAP` has been removed in #20894
* `console.log()` doesn't issue `TTYWRAP` nor `SIGNALWRAP`

I don't know which PR caused that `console.log()` is no longer using
`TTYWRAP` and `SIGNALWRAP`; I think it was between 8.4.0 and 8.5.0.

PR-URL: #24050
Refs: #20894
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@codebytere codebytere Shelley Vohr
GPG key ID: F13993A75599653C Learn about signing commits
0d65b4b

MylesBorins added a commit that referenced this pull request Dec 26, 2018

@Flarna @MylesBorins
doc: correct async_hooks sample outputs 
Correct the output of async_hooks samples
* `TIMERWRAP` has been removed in #20894
* `console.log()` doesn't issue `TTYWRAP` nor `SIGNALWRAP`

I don't know which PR caused that `console.log()` is no longer using
`TTYWRAP` and `SIGNALWRAP`; I think it was between 8.4.0 and 8.5.0.

PR-URL: #24050
Refs: #20894
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
0260db5

@codebytere codebytere referenced this pull request Jan 4, 2019

Merged

v10.15.1 proposal #25346

This was referenced Jan 29, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed

This was referenced Jan 30, 2019

Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.