src: remove defunct timer_wrap file
Unused since the excellent refactoring in 2930bd1, which also removed `src/timer_wrap.cc` from `node.gyp`. If you try and get at the binding on a v11.0-pre build, you'll get an error, since the file is no longer in the GYP build. ``` Jonathans-MBP:node jon$ ./node -v v11.0.0-pre Jonathans-MBP:node jon$ ./node -e "process.binding('timer_wrap')" internal/bootstrap/loaders.js:81 mod = bindingObj[module] = getBinding(module); ^ Error: No such module: timer_wrap at process.binding (internal/bootstrap/loaders.js:81:36) at [eval]:1:9 at Script.runInThisContext (vm.js:89:20) at Object.runInThisContext (vm.js:286:38) at Object.<anonymous> ([eval]-wrapper:6:22) at Module._compile (internal/modules/cjs/loader.js:689:30) at evalScript (internal/bootstrap/node.js:562:27) at startup (internal/bootstrap/node.js:248:9) at bootstrapNodeJSCore (internal/bootstrap/node.js:595:3) ``` Refs: nodejs#20894

Unused since the excellent refactoring in 2930bd1, which also removed `src/timer_wrap.cc` from `node.gyp`. If you try and get at the binding on a v11.0-pre build, you'll get an error, since the file is no longer in the GYP build. ``` Jonathans-MBP:node jon$ ./node -v v11.0.0-pre Jonathans-MBP:node jon$ ./node -e "process.binding('timer_wrap')" internal/bootstrap/loaders.js:81 mod = bindingObj[module] = getBinding(module); ^ Error: No such module: timer_wrap at process.binding (internal/bootstrap/loaders.js:81:36) at [eval]:1:9 at Script.runInThisContext (vm.js:89:20) at Object.runInThisContext (vm.js:286:38) at Object.<anonymous> ([eval]-wrapper:6:22) at Module._compile (internal/modules/cjs/loader.js:689:30) at evalScript (internal/bootstrap/node.js:562:27) at startup (internal/bootstrap/node.js:248:9) at bootstrapNodeJSCore (internal/bootstrap/node.js:595:3) ``` Refs: nodejs#20894
src: remove defunct timer_wrap file
Unused since the excellent refactoring in 2930bd, which also removed `src/timer_wrap.cc` from `node.gyp`. If you try and get at the binding on a v11.0-pre build, you'll get an error, since the file is no longer in the GYP build. ``` Jonathans-MBP:node jon$ ./node -v v11.0.0-pre Jonathans-MBP:node jon$ ./node -e "process.binding('timer_wrap')" internal/bootstrap/loaders.js:81 mod = bindingObj[module] = getBinding(module); ^ Error: No such module: timer_wrap at process.binding (internal/bootstrap/loaders.js:81:36) at [eval]:1:9 at Script.runInThisContext (vm.js:89:20) at Object.runInThisContext (vm.js:286:38) at Object.<anonymous> ([eval]-wrapper:6:22) at Module._compile (internal/modules/cjs/loader.js:689:30) at evalScript (internal/bootstrap/node.js:562:27) at startup (internal/bootstrap/node.js:248:9) at bootstrapNodeJSCore (internal/bootstrap/node.js:595:3) ``` PR-URL: #21777 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Refs: #20894
nodejs · apapirovski · apapirovski · apapirovski · May 22, 2018 · apapirovski
diff --git a/src/env.cc b/src/env.cc
@@ -450,6 +459,59 @@ void Environment::RunAndClearNativeImmediates() {
 }


+void Environment::ScheduleTimer(int64_t duration) {
diff --git a/src/env.cc b/src/env.cc
+  do {
+    TryCatch try_catch(env->isolate());
+    try_catch.SetVerbose(true);
+    ret = cb->Call(env->context(), process, 1, args);
diff --git a/src/env.cc b/src/env.cc
+
+  if (expiry != 0) {
+    int64_t duration =
+      abs(expiry) - (uv_now(env->event_loop()) - env->timer_base());
diff --git a/src/timers.cc b/src/timers.cc
+  result->Set(env->context(), 1, timer_toggle_ref_function).FromJust();
+  result->Set(env->context(), 2,
+              env->immediate_info()->fields().GetJSArray()).FromJust();
+  result->Set(env->context(), 3, imm_toggle_ref_function).FromJust();
diff --git a/src/timer_wrap.cc b/src/timer_wrap.cc
-// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
-// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
-// USE OR OTHER DEALINGS IN THE SOFTWARE.
-
diff --git a/test/parallel/test-inspector-tracing-domain.js b/test/parallel/test-inspector-tracing-domain.js
@@ -52,7 +52,7 @@ async function test() {
                        'node.perf.timerify', 'v8'],
                       categories);

-  const traceConfig = { includedCategories: ['node'] };
+  const traceConfig = { includedCategories: ['v8'] };
diff --git a/lib/timers.js b/lib/timers.js
@@ -53,8 +58,9 @@ const kCount = 0;
 const kRefCount = 1;
 const kHasOutstanding = 2;

-const [immediateInfo, toggleImmediateRef] =
-  setupTimers(processImmediate, processTimers);
+// Call into C++ to assing callbacks that are responsible for processing
diff --git a/lib/timers.js b/lib/timers.js
    listOnTimeout(list, now);
-    ran = true;
diff --git a/src/env.cc b/src/env.cc
@@ -161,6 +163,9 @@ void Environment::Start(int argc,
  HandleScope handle_scope(isolate());
  Context::Scope context_scope(context());

+  uv_timer_init(event_loop(), timer_handle());
diff --git a/src/env.cc b/src/env.cc
+
+  Local<Function> cb = env->timers_callback_function();
+  MaybeLocal<Value> ret;
+  Local<Value> args[] = { env->GetNow() };
diff --git a/src/env.cc b/src/env.cc
+    TryCatch try_catch(env->isolate());
+    try_catch.SetVerbose(true);
+    ret = cb->Call(env->context(), process, arraysize(args), args);
+  } while (ret.IsEmpty());
diff --git a/src/env.cc b/src/env.cc
+
+  if (expiry_ms != 0) {
+    int64_t duration_ms =
+      abs(expiry_ms) - (uv_now(env->event_loop()) - env->timer_base());
diff --git a/src/env.cc b/src/env.cc
+    }
+  } else if (has_ref) {
+    uv_unref(h);
+  }
diff --git a/src/timers.cc b/src/timers.cc
+#include <stdint.h>
+
+namespace node {
+namespace timers {
diff --git a/test/parallel/test-inspector-tracing-domain.js b/test/parallel/test-inspector-tracing-domain.js
@@ -52,7 +52,7 @@ async function test() {
                        'node.perf.timerify', 'v8'],
                       categories);

-  const traceConfig = { includedCategories: ['node'] };
+  const traceConfig = { includedCategories: ['v8'] };
diff --git a/test/parallel/test-timers-ordering.js b/test/parallel/test-timers-ordering.js
 const N = 30;

 let last_i = 0;
-let last_ts = 0;
+const [seconds, nanoseconds] = process.hrtime();
+let last_ts = (seconds * 1e3 + nanoseconds * 1e-6) | 0;