★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23977Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof reading #23977

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@mscdex mscdex

@refack refack

@vsemozhetbyt vsemozhetbyt

@jasnell jasnell

@addaleax addaleax

@cjihrig cjihrig

@lundibundi lundibundi

@trivikr trivikr

Assignees
No one assigned
Labels
author ready doc dont-land-on-v8.x land-on-v10.x meta
Projects
None yet
Milestone
No milestone
@jagannathBhat
Copy link
Contributor

jagannathBhat commented Oct 30, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@jagannathBhat
Proof reading
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
610bdac

@nodejs-github-bot nodejs-github-bot added the doc label Oct 30, 2018

@lundibundi

lundibundi approved these changes Oct 30, 2018
View changes

@vsemozhetbyt

vsemozhetbyt approved these changes Oct 30, 2018
View changes

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Oct 30, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the meta label Oct 30, 2018

@addaleax

addaleax approved these changes Oct 30, 2018
View changes

Show resolved Hide resolved COLLABORATOR_GUIDE.md Outdated
@cjihrig

cjihrig approved these changes Oct 30, 2018
View changes

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Oct 30, 2018

fast-tracking?

IMHO it should be fixed first.
@vsemozhetbyt

This comment was marked as resolved.

Sign in to view
Copy link
Member

vsemozhetbyt commented Oct 30, 2018

@refack It can be fixed on landing. If we do not want to use it for bot-checking)

@seishun seishun referenced this pull request Oct 30, 2018

Closed

Bits of proof reading work #23978

0 of 4 tasks complete
@jasnell

jasnell approved these changes Oct 30, 2018
View changes

@trivikr

trivikr approved these changes Oct 31, 2018
View changes

@Trott
fixup! nit
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ed7d855
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Oct 31, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1436/

@Trott Trott added the author ready label Oct 31, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 2, 2018

Landed in 67d74e4

@Trott Trott closed this Nov 2, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 2, 2018

@jagannathBhat @Trott
doc: improve COLLABORATOR_GUIDE 
PR-URL: nodejs#23977
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
67d74e4

targos added a commit that referenced this pull request Nov 2, 2018

@jagannathBhat @targos
doc: improve COLLABORATOR_GUIDE 
PR-URL: #23977
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
b8a71be

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

This was referenced Nov 15, 2018

Closed
Closed
Closed
Closed
Closed
Closed

MylesBorins added a commit that referenced this pull request Nov 27, 2018

@jagannathBhat @MylesBorins
doc: improve COLLABORATOR_GUIDE 
PR-URL: #23977
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
Loading status checks…
17c2ddd

@MylesBorins MylesBorins added dont-land-on-v8.x land-on-v10.x labels Nov 27, 2018

@codebytere codebytere referenced this pull request Nov 27, 2018

Closed

v10.13.1 proposal #24675

rvagg added a commit that referenced this pull request Nov 28, 2018

@jagannathBhat @rvagg
doc: improve COLLABORATOR_GUIDE 
PR-URL: #23977
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
823b8b9

MylesBorins added a commit that referenced this pull request Nov 29, 2018

@jagannathBhat @MylesBorins
doc: improve COLLABORATOR_GUIDE 
PR-URL: #23977
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
00c0539

@codebytere codebytere referenced this pull request Nov 29, 2018

Merged

v10.14.2 proposal #24727

MylesBorins added a commit that referenced this pull request Dec 3, 2018

@jagannathBhat @MylesBorins
doc: improve COLLABORATOR_GUIDE 
PR-URL: #23977
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
52215a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.