★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/23977/filesNouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof reading #23977

Closed
wants to merge 2 commits into from
Closed

Proof reading #23977

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
610bdac
Proof reading
jagannathBhat Oct 30, 2018
ed7d855
fixup! nit
Trott Oct 31, 2018
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+2 −2
Diff settings

Always

Just for now
Copy path View file
4 COLLABORATOR_GUIDE.md
@@ -497,7 +497,7 @@ This should be done where a pull request:

Assign the `tsc-review` label or @-mention the
`@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][].
Do not use the GitHub UI on the right hand side to assign to
Do not use the GitHub UI on the right-hand side to assign to
`@nodejs/tsc` or request a review from `@nodejs/tsc`.

The TSC should serve as the final arbiter where required.
@@ -528,7 +528,7 @@ The TSC should serve as the final arbiter where required.
you are unsure exactly how to format the commit messages, use the commit log
as a reference. See [this commit][commit-example] as an example.

For PRs from first time contributors, be [welcoming](#welcoming-first-time-contributors).
For PRs from first-time contributors, be [welcoming](#welcoming-first-time-contributors).
Also, verify that their git settings are to their liking.

All commits should be self-contained, meaning every commit should pass all
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.