★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/21579Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in fs.md #21579

Closed

Conversation

Projects
None yet
4 participants
@hugojosefson
Copy link
Contributor

hugojosefson commented Jun 28, 2018 •

Fixes simple typo of excludiing to excluding.

  • make -j4 test (UNIX) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: fix typo in fs.md
Fixes simple typo of `excludiing` to `excluding`.
@vsemozhetbyt
Copy link
Member

vsemozhetbyt left a comment

Thank you!

@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Jun 28, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott Trott added the fast-track label Jun 28, 2018

@Trott

Trott approved these changes Jun 28, 2018

@Trott

This comment has been minimized.

@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Jun 28, 2018

@Trott BTW, should we run an explicit CI-lite in such cases since the CI-lite is launched automatically now as Travis CI?

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jun 28, 2018

@Trott BTW, should we run an explicit CI-lite in such cases since the CI-lite is launched automatically now as Travis CI?

CI Lite is only launched for PRs opened by Collaborators. It was not automatically launched on this PR, for example.

We could choose to decide that the Travis CI is a sufficient equivalent to Lite CI but I would not want to make that call unilaterally. :-D

@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Jun 28, 2018

But it did launch on this PR, I've seen this result before your launch:

https://github.com/nodejs/node/pull/21579/checks?check_run_id=5686153

Maybe it is launched for doc only PRs whoever makes them?

@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Jun 28, 2018 •

See for example #21564: CI-lite is performed in https://github.com/nodejs/node/pull/21564/checks

Oops, and that PR is not doc-only...

Is this a security breach?

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jun 28, 2018

@vsemozhetbyt Both of those links are to Travis CI runs. Those run automatically on all PRs. That's fine.

The Jenkins ci.nodejs.org node-test-pull-request-lite jobs are the ones that only run automatically for PRs opened by Collaborators.

@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Jun 28, 2018

What is the difference? Since Travis CI seems to contain the same linux-one and linter job.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jun 28, 2018

Travis CI is sandboxed, so it's OK to run automatically for everyone.

However, it makes available only a fraction of the platforms that we test on ourselves and that we care about. So (at this time anyway) it can only replace or duplicate a few functions of our own CI.

vsemozhetbyt added a commit that referenced this pull request Jun 28, 2018

doc: fix typo in fs.md
Fixes simple typo of `excludiing` to `excluding`.

PR-URL: #21579
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Jun 28, 2018

Landed in d6397af
Thank you!

@hugojosefson hugojosefson deleted the hugojosefson:doc-fix-typo-excludiing branch Jun 29, 2018

targos added a commit that referenced this pull request Jun 29, 2018

doc: fix typo in fs.md
Fixes simple typo of `excludiing` to `excluding`.

PR-URL: #21579
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@targos targos referenced this pull request Jul 3, 2018

Merged

v10.6.0 proposal #21629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.