Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updoc: fix typo in fs.md #21579
Conversation
nodejs-github-bot
added
doc
fs
labels
Jun 28, 2018
vsemozhetbyt
approved these changes
Jun 28, 2018
|
Thank you! |
vsemozhetbyt
added
the
author ready
label
Jun 28, 2018
This comment has been minimized.
This comment has been minimized.
|
Node.js Collaborators, please, add |
Trott
added
the
fast-track
label
Jun 28, 2018
Trott
approved these changes
Jun 28, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@Trott BTW, should we run an explicit CI-lite in such cases since the CI-lite is launched automatically now as Travis CI? |
This comment has been minimized.
This comment has been minimized.
CI Lite is only launched for PRs opened by Collaborators. It was not automatically launched on this PR, for example. We could choose to decide that the Travis CI is a sufficient equivalent to Lite CI but I would not want to make that call unilaterally. :-D |
This comment has been minimized.
This comment has been minimized.
|
But it did launch on this PR, I've seen this result before your launch: https://github.com/nodejs/node/pull/21579/checks?check_run_id=5686153 Maybe it is launched for doc only PRs whoever makes them? |
This comment has been minimized.
This comment has been minimized.
|
See for example #21564: CI-lite is performed in https://github.com/nodejs/node/pull/21564/checks Oops, and that PR is not doc-only... Is this a security breach? |
This comment has been minimized.
This comment has been minimized.
|
@vsemozhetbyt Both of those links are to Travis CI runs. Those run automatically on all PRs. That's fine. The Jenkins ci.nodejs.org node-test-pull-request-lite jobs are the ones that only run automatically for PRs opened by Collaborators. |
This comment has been minimized.
This comment has been minimized.
|
What is the difference? Since Travis CI seems to contain the same linux-one and linter job. |
This comment has been minimized.
This comment has been minimized.
|
Travis CI is sandboxed, so it's OK to run automatically for everyone. However, it makes available only a fraction of the platforms that we test on ourselves and that we care about. So (at this time anyway) it can only replace or duplicate a few functions of our own CI. |
vsemozhetbyt
added a commit
that referenced
this pull request
Jun 28, 2018
This comment has been minimized.
This comment has been minimized.
|
Landed in d6397af |
hugojosefson commentedJun 28, 2018
•
edited
Fixes simple typo of
excludiingtoexcluding.make -j4 test(UNIX) passes