errors: fix undefined HTTP2 and tls errors #21564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes implementation of tls, HTTP2 error with documentation
vsemozhetbyt
reviewed
Jun 27, 2018
| <a id="ERR_TLS_RENEGOTIATE"></a> | ||
| ### ERR_TLS_RENEGOTIATE | ||
|
|
||
| An attempt was made to renegotiate TLS session failed. |
There was a problem hiding this comment.
Is this wording a bit off? Maybe An attempt made to renegotiate... or even An attempt to renegotiate...?
There was a problem hiding this comment.
I was not sure, thats why I asked everyone here #21440 about the message
There was a problem hiding this comment.
An attempt to renegotiate the TLS session failed.
|
ping @nodejs/http2 |
|
@vsemozhetbyt @jasnell are you now ok for this to land? |
|
Yep
…On Mon, Jul 9, 2018, 23:45 Matteo Collina ***@***.***> wrote:
@vsemozhetbyt <https://github.com/vsemozhetbyt> @jasnell
<https://github.com/jasnell> are you now ok for this to land?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21564 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAa2eaLyorhQpQvBRiqcpTruplaW7Ronks5uFE2jgaJpZM4U5zDb>
.
|
|
Let's land this tomorrow with the wording from @jasnell if there are no amendments by that time. |
|
Landed in 3950a3e |
Merged
kjin
added a commit
to kjin/node
that referenced
this issue
Aug 23, 2018
Includes implementation of tls, HTTP2 error with documentation. PR-URL: nodejs#21564 Refs: nodejs#21440 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
kjin
added a commit
to kjin/node
that referenced
this issue
Sep 25, 2018
Includes implementation of tls, HTTP2 error with documentation. PR-URL: nodejs#21564 Refs: nodejs#21440 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
kjin
added a commit
to kjin/node
that referenced
this issue
Oct 16, 2018
Includes implementation of tls, HTTP2 error with documentation. PR-URL: nodejs#21564 Refs: nodejs#21440 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Includes implementation of tls, HTTP2 error with documentation
Ref: #21440
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes