★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/18017Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: assign deprecation code for setAuthTag/GCM #18017

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@mcollina mcollina

@jasnell jasnell

@lpinca lpinca

@targos targos

@joyeecheung joyeecheung

Assignees
No one assigned
Labels
C++ crypto deprecations semver-major
Projects
None yet
Milestone
  10.0.0
7 participants
@tniessen @jasnell @joyeecheung @mcollina @lpinca @targos @nodejs-github-bot
@tniessen
Copy link
Member

tniessen commented Jan 6, 2018

#17566 added a warning when invalid GCM tag lengths are used. As a preparation for #17825, assign a deprecation code before moving it to end-of-life.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto
@tniessen
crypto: assign deprecation code for setAuthTag/GCM
Verified
This commit was signed with a verified signature.
@tniessen tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
Loading status checks…
83bdf99

@tniessen tniessen requested a review from joyeecheung Jan 6, 2018

@nodejs-github-bot nodejs-github-bot added C++ crypto labels Jan 6, 2018

@joyeecheung

joyeecheung approved these changes Jan 6, 2018
View changes

@jasnell jasnell added the semver-major label Jan 6, 2018

@jasnell

jasnell approved these changes Jan 6, 2018
View changes

@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

tniessen commented Jan 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12437/
@lpinca

lpinca approved these changes Jan 7, 2018
View changes

doc/api/deprecations.md Outdated
Node.js supports all GCM authentication tag lengths which are accepted by
OpenSSL when calling [`decipher.setAuthTag()`][]. This behavior will change in
a future version at which point only authentication tag lengths of 128, 120,
112, 104, 96, 64 and 32 bits will be allowed. Authentication tags whose length

This comment has been minimized.

Sign in to view
Copy link
@lpinca

lpinca Jan 7, 2018

Member

Tiny nit: serial comma for consistency.

This comment has been minimized.

Sign in to view
Copy link
@tniessen

tniessen Jan 7, 2018

Author Member

Done, thank you!
@tniessen
fixup! crypto: assign deprecation code for setAuthTag/GCM
Verified
This commit was signed with a verified signature.
@tniessen tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
Loading status checks…
05ac671
@jasnell

This comment has been minimized.

Sign in to view
Copy link
Member

jasnell commented Jan 9, 2018

Ping @nodejs/tsc
@mcollina

mcollina approved these changes Jan 10, 2018
View changes

Copy link
Member

mcollina left a comment

LGTM
@targos

targos approved these changes Jan 10, 2018
View changes

@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member

joyeecheung commented Jan 10, 2018

Previous CI stopped. New CI: https://ci.nodejs.org/job/node-test-pull-request/12488/

@tniessen tniessen added this to the 10.0.0 milestone Jan 11, 2018

@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

tniessen commented Jan 14, 2018

Pre-land CI: https://ci.nodejs.org/job/node-test-pull-request/12525/

tniessen added a commit that referenced this pull request Jan 14, 2018

@tniessen
crypto: assign deprecation code for setAuthTag/GCM 
PR-URL: #18017
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@tniessen tniessen Tobias Nießen
GPG key ID: 718207F8FD156B70 Learn about signing commits
858b48b
@tniessen

This comment has been minimized.

Sign in to view
Copy link
Member Author

tniessen commented Jan 14, 2018

Landed in 858b48b.

@tniessen tniessen closed this Jan 14, 2018

This was referenced Jan 17, 2018

Closed
Closed

@tniessen tniessen referenced this pull request Feb 4, 2018

Closed

crypto: throw on invalid authentication tag length #17825

4 of 4 tasks complete

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

@tniessen @msoechting
crypto: assign deprecation code for setAuthTag/GCM 
PR-URL: nodejs#18017
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
fc82d5d

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

@tniessen @msoechting
crypto: assign deprecation code for setAuthTag/GCM 
PR-URL: nodejs#18017
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
90ed4fb

@tniessen tniessen added the deprecations label Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.