★ wanayoo — archive 1999 https://github.com/livecode/livecode-ide/pull/2145Nouvelle recherche | Portail wanayoo
Skip to content

/ livecode-ide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[[ Bug 22942 ]] Ensure the shellcommand defaults to COMSPEC on Windows #2145

Merged
merged 1 commit into from Oct 19, 2020
Merged

[[ Bug 22942 ]] Ensure the shellcommand defaults to COMSPEC on Windows #2145

merged 1 commit into from Oct 19, 2020

Conversation

@livecodepanos
Copy link
Contributor

@livecodepanos livecodepanos commented Oct 15, 2020

No description provided.

@livecodepanos livecodepanos added this to the 9.6.2-rc-1 milestone Oct 15, 2020
@livecodepanos livecodepanos mentioned this pull request Oct 15, 2020
Merged
@runrevmark
runrevmark requested changes Oct 16, 2020
View changes
Toolset/libraries/revcommonlibrary.livecodescript Outdated
@@ -133,11 +133,6 @@ on revSetWindowsShellCommand
if the platform is not "Win32" then exit revSetWindowsShellCommand
set the hideConsoleWindows to true
if $COMSPEC is not empty then set the shellCommand to $COMSPEC

This comment has been minimized.

Sign in to view
@runrevmark

runrevmark Oct 16, 2020
Contributor

This can just be:

set the shellCommand to $COMSPEC

Since we are making it an error to try and shell() if shellCommand is empty.
@livecodepanos
[[ Bug 22942 ]] Ensure the shellcommand defaults to COMSPEC on Windows
Loading status checks…
7a3800e
@livecodepanos livecodepanos force-pushed the bugfix-22942 branch from 6077e0a to 7a3800e Oct 16, 2020
@runrevmark
runrevmark approved these changes Oct 19, 2020
View changes
@runrevmark
Copy link
Contributor

@runrevmark runrevmark commented Oct 19, 2020

@livecode-vulcan review ok 7a3800e
livecode-vulcan added a commit to livecode/livecode that referenced this pull request Oct 19, 2020
@livecode-vulcan
Auto-merge pull request #7454 from livecodepanos/bugfix-22942
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
aa28580 
[[ Bug 22942 ]] Ensure the shellcommand defaults to COMSPEC on Windows

Goes together with livecode/livecode-ide#2145
@livecode-vulcan
Copy link

@livecode-vulcan livecode-vulcan commented Oct 19, 2020

💙 review by @runrevmark ok 7a3800e
@livecodepanos livecodepanos merged commit f309d60 into develop-9.6 Oct 19, 2020
2 checks passed
2 checks passed
continuous-integration/vulcan/cla Contributor Agreement signed by @livecodepanos
continuous-integration/vulcan/review Approved by reviewer @runrevmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runrevmark runrevmark

Assignees

@livecodepanos livecodepanos

Labels
vulcan/reviewed
Projects
None yet
Milestone
9.6.2-rc-1
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@livecodepanos @runrevmark @livecode-vulcan
You can’t perform that action at this time.