Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[[ Bug 22942 ]] Ensure the shellcommand defaults to COMSPEC on Windows #7454
Conversation
|
With this patch there is the possibility that In This will cause an error to be thrown if the shellCommand is empty - rather than it trying to run launch a process with a malformed command line (which will probably fail anyway, but this stops the attempt!). |
engine/src/dskw32.cpp
Outdated
| @@ -1534,8 +1534,8 @@ struct MCWindowsDesktop: public MCSystemInterface, public MCWindowsSystemService | |||
| } | |||
| } | |||
|
|
|||
| // On NT systems 'cmd.exe' is the command processor | |||
| MCValueAssign(MCshellcmd, MCSTR("cmd.exe")); | |||
| // On NT systems use the env var COMSPEC (= C:\Windows\System32\cmd.exe) | |||
runrevmark
Oct 16, 2020
Contributor
/* Default the shellCommand to the value of the COMSPEC environment
* variable. */
/* Default the shellCommand to the value of the COMSPEC environment
* variable. */
engine/src/dskw32.cpp
Outdated
| // On NT systems 'cmd.exe' is the command processor | ||
| MCValueAssign(MCshellcmd, MCSTR("cmd.exe")); | ||
| // On NT systems use the env var COMSPEC (= C:\Windows\System32\cmd.exe) | ||
| MCS_getenv(MCSTR("COMSPEC"), MCshellcmd); |
runrevmark
Oct 16, 2020
Contributor
So we should use MCValueAssign here like elsewhere:
MCAutoStringRef t_comspec;
if (MCS_getenv(MCSTR("COMSPEC"), &t_comspec))
{
MCValueAssign(MCshellcmd, *t_comspec);
}
else
{
MCValueAssign(MCshellcmd, kMCEmptyString);
}
So we should use MCValueAssign here like elsewhere:
MCAutoStringRef t_comspec;
if (MCS_getenv(MCSTR("COMSPEC"), &t_comspec))
{
MCValueAssign(MCshellcmd, *t_comspec);
}
else
{
MCValueAssign(MCshellcmd, kMCEmptyString);
}
| @@ -22,8 +22,8 @@ set the shellCommand to "/bin/sh/ksh" | |||
| Value: | |||
| The <shellCommand> is a string. | |||
| By default, the <shellCommand> <property> is set to "/bin/sh" (the | |||
| Bourne shell) on <Unix|Unix systems>, and "command.com" on Windows | |||
| systems. | |||
| Bourne shell) on <Unix|Unix systems>, and to the environment variable "COMSPEC" on Windows | |||
runrevmark
Oct 16, 2020
Contributor
and to the value of the COMSPEC environment variable on Windows systems.
(I don't think there's a need to say anymore than that).
Should Windows be referred to like <Windows|Windows systems> as it is for Unix?
and to the value of the COMSPEC environment variable on Windows systems.
(I don't think there's a need to say anymore than that).
Should Windows be referred to like <Windows|Windows systems> as it is for Unix?
docs/notes/bugfix-22942.md
Outdated
| @@ -0,0 +1 @@ | |||
| # Ensure the shellcommand defaults to COMSPEC on Windows | |||
runrevmark
Oct 16, 2020
Contributor
shellCommand
shellCommand
b4d40db
to
d8cb11f
|
@livecode-vulcan review ok d8cb11f |
|
|
livecode-vulcan
added a commit
that referenced
this pull request
Oct 19, 2020
[[ Bug 22942 ]] Ensure the shellcommand defaults to COMSPEC on Windows Goes together with livecode/livecode-ide#2145
|
9bd23b2
into
livecode:develop-9.6
4 checks passed
4 checks passed
continuous-integration/vulcan/cla
Contributor Agreement signed by @livecodepanos
continuous-integration/vulcan/pr
The Vulcan build succeeded on 15 builders
continuous-integration/vulcan/review
Approved by reviewer @runrevmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Goes together with livecode/livecode-ide#2145