★ wanayoo — archive 1999 https://github.com/xtensor-stack/xtensor-python/pull/202Nouvelle recherche | Portail wanayoo
Skip to content

/ xtensor-python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytensor overload resolution in pybind11. #202

Merged
merged 1 commit into from Nov 25, 2019
Merged

Fix pytensor overload resolution in pybind11. #202

merged 1 commit into from Nov 25, 2019

Conversation

@zhujun98
Copy link
Contributor

zhujun98 commented Aug 6, 2019

As discussed in #178.

@SylvainCorlay I am not sure whether this is a good solution.
@zhujun98
Copy link
Contributor Author

zhujun98 commented Aug 24, 2019

I have no ideal why CI failed. Could someone have a look? Thank you!
@JohanMabille
Copy link
Member

JohanMabille commented Aug 26, 2019 •
edited

Travis: It looks like conda cannot find cmake on conda-forge. I retart the build to see if it was an incident of if there is something more serious.

Appveyor: on Windows this seems to be a version conflict of Python, we download last miniconda (i.e 3.7) while the conditions on dependencies are < 3.7
@JohanMabille
Copy link
Member

JohanMabille commented Aug 26, 2019

The root cause of the error on travis is the miniconda distribution we use is too old.
I'm upgrading to latest miniconda and more recent pybind11, once #205 has been merged, you can rebase on master and force push, this should fix your issues.
@zhujun98
Copy link
Contributor Author

zhujun98 commented Aug 26, 2019

Thanks a lot! I will keep an eye on #205
@zhujun98
Fix pytensor overload resolution in pybind11.
Loading status checks…
2af1f40
@zhujun98 zhujun98 force-pushed the zhujun98:fix_pytensor_overload_resolution branch from 025d1e5 to 2af1f40 Aug 28, 2019
@SylvainCorlay
Copy link
Member

SylvainCorlay commented Nov 25, 2019

Thanks @zhujun98.
@SylvainCorlay SylvainCorlay merged commit 719b9d1 into xtensor-stack:master Nov 25, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zhujun98 @JohanMabille @SylvainCorlay
You can’t perform that action at this time.