★ wanayoo — archive 1999 https://github.com/utPLSQL/utPLSQL/pull/783Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding suite check API & performance improvements #783

Merged
merged 34 commits into from Nov 18, 2018
Merged

Conversation

@jgebal
Copy link
Member

@jgebal jgebal commented Nov 17, 2018

  • added new APIs in ut_runner
    • get_suites_info - resolves #785
    • is_test - resolves #788
    • is_suite - resolves #787
    • has_suites - resolves #786

Added suite level cache as a complementary cache on top of annotations cache.
Improved performance of suite-builder by using IN OUT NOCOPY and avoiding large data variable copying/assignments.
Minimized the amount of data scanned after package compilation.

We now join to all_objects only when executing user doesn't have execute any and is not owner of test packages.

Resolves #778

Reworked output buffer and reporters for performance (we now do bulk inserts into buffer where applicable) - resolves #777

jgebal added 24 commits Oct 30, 2018
…he infamous ORA-00600

`ORA-00600: internal error code, arguments: [pfrobj.c: invalid RTTI for Object], [], [], [], [], [], [], [], [], [], [], []``
Refactored lots of code for suite parsing/building.
(Acceptance) tests need rework due to changes in test execution ordering.
One problem to be solved. Oracle nested tables are **unordered!** and we need an ordered list of before/after items that contain CLOB column, so cannot be varray.
Added `seq_no`, numbering before storage and sorting after retrieval.
Added static schema name rather than bind variable.
Adding new function to return list of suites and tests.
Changed functions to procedures to avoid copying of large memmory segments.
This reverts commit 3543e3d
…ormation based on info suite cache.

Suite cache is refreshed when calling procedure (as needed).
…s not used uin prior versions.

Added functions `is_test`, `is_suite`, `has_suite` to perform checks for test/suite existance at prcedure, package, schema level.
The script will now automatically copy `*.jar` files into `/utPLSQL-cli/lib` directory.
@jgebal jgebal added this to the v3.1.3 milestone Nov 17, 2018
@jgebal jgebal requested review from Pazus, lwasylow and PhilippSalvisberg Nov 17, 2018
Fixed failing test.
Copy link

@utplsql-travis utplsql-travis left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 6

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  2. Code Smell Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
  3. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  4. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

Copy link

@utplsql-travis utplsql-travis left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 6

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
  2. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  3. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  4. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

Copy link

@utplsql-travis utplsql-travis left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 6

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
  2. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  3. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  4. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

Copy link

@utplsql-travis utplsql-travis left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 6

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  2. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  3. Code Smell Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
  4. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

jgebal added 2 commits Nov 17, 2018
Added default value for owner, when calling `get_suites_info`
Copy link

@utplsql-travis utplsql-travis left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 5

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  2. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  3. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

Copy link

@utplsql-travis utplsql-travis left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 5

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  2. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  3. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

Copy link

@utplsql-travis utplsql-travis left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 5

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  2. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  3. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

Copy link

@utplsql-travis utplsql-travis left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 5

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  2. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)
  3. Code Smell Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

Added additional tests to:
- cover functionality of reporting warnings on transaction invalidation with sub-suites.
- cover functionality of failing a test in sub-suite when beforeall fails in parent suite with logical suites in between.
Refactored `ut_teamcity_reporter` a bit.
@jgebal jgebal force-pushed the feature/suite_query_api branch from 26eb3ca to 74ec9a1 Nov 18, 2018
jgebal added 6 commits Nov 18, 2018
Disabled coverage gathering on old tests.
Fixed issue with warnings not getting shown.
@jgebal jgebal merged commit 3a1227e into develop Nov 18, 2018
4 checks passed
4 checks passed
SonarCloud Code Quality check passed; 95.6% New code coverage; 94.0% Est. post-merge coverage
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on feature/suite_query_api at 95.849%
Details
@jgebal jgebal deleted the feature/suite_query_api branch Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.