★ wanayoo — archive 1999 https://github.com/utPLSQL/utPLSQL/pull/486Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example for custom expectation-fail message in docs #486

Merged
merged 2 commits into from Sep 29, 2017

Conversation

@pesse
Copy link
Member

@pesse pesse commented Sep 28, 2017

Fixes #485

@ghost ghost assigned pesse Sep 28, 2017
@ghost ghost added the in progress label Sep 28, 2017
Copy link
Member

@jgebal jgebal left a comment

Hi @pesse ,
Can you update the Concepts section?
The syntax should include 'message' as an optional parameter.

I think that the whole section you are proposing to add, could go as sup-section under the Concepts.
Please change the error to failure.

Thanks for the contribution. It's a nice addition to the documentation.

@@ -471,3 +471,55 @@ end;
```
Since NULL is neither *true* nor *not true*, both expectations will report failure.

# Provide a custom error message

This comment has been minimized.

@jgebal

jgebal Sep 29, 2017
Member

To be consistent with the rest of document please change that to: Adding custom failure message

# Provide a custom error message
Expectations allow you to provide a custom error message as second argument:
````sql
ut.expect( a_actual {data-type}, 'custom error message if expectation fails' ).to_{matcher};

This comment has been minimized.

@jgebal

jgebal Sep 29, 2017
Member

Can you replace the 'error message' with 'failure message' or just 'custom message'.
There is a difference between error and failure as we define errored test as a test procedure that raised an unhandled exception.

replaced "error" with "failure", moved section as sub-section of Concepts, reworked Concepts slightly
@jgebal
jgebal approved these changes Sep 29, 2017
Copy link
Member

@jgebal jgebal left a comment

Looks great!
Thanks @pesse

@jgebal jgebal added this to the v3.1.0 milestone Sep 29, 2017
@jgebal jgebal merged commit e448d70 into develop Sep 29, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.551%
Details
@ghost ghost removed the in progress label Sep 29, 2017
@jgebal jgebal deleted the docs_exampleForCustomExpectationFailMessage branch Oct 20, 2017
@jgebal jgebal modified the milestones: v3.1.0, v3.0.4 Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.