★ wanayoo — archive 1999 https://github.com/unifiedjs/unifiedjs.github.io/pull/9Nouvelle recherche | Portail wanayoo
Skip to content

/ unifiedjs.github.io

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide for IE #9

Open
wants to merge 2 commits into
base: src
from
Open

Add guide for IE #9

wants to merge 2 commits into from

Conversation

@jasonqsong
Copy link

jasonqsong commented Jun 29, 2019

No description provided.

@jasonqsong
Add guide for IE
Loading status checks…
9dce460
@jasonqsong
Copy link
Author

jasonqsong commented Jun 29, 2019

This is discussed in unifiedjs/unified#55 . I'm not quite sure if a "guide" is too much for this question. Perhaps a FAQ is a better place.
@ChristianMurphy ChristianMurphy requested review from Murderlon and wooorm Jun 29, 2019
@wooorm
Merge branch 'src' into src
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5e6ea42
@Murderlon
Murderlon requested changes Jul 1, 2019
View changes
Copy link
Member

Murderlon left a comment •
edited

Thanks for taking the time for making this!

As of now I'd say this guide is a bit too specific as it's just for IE. We found out browser support is a common question and, as mentioned in #7 (comment), we'd like to tackle that in a guide that encapsulates browser support in general. Moreover, the current state of the guide would need some grooming to align with the previous guides. The latter can take quite some iterations and possibly become a bit nit-picky so I have a proposal for you. If you change the following points I am willing to pick it up from there and make it comply with the previous guides.

Requested changes:

  • Switch from “Use unified in Internet Explorer” to “Setting up tooling for browser support”
  • Add sections for (some) of the following on how to compile unified with:
    • Rollup
    • WebPack
    • Angular CLI
    • Create React App
    • Vue CLI
  • Switch from bash commands (such as cat > src/index.js <<EOF...) to code snippets.
  • Switch from screenshots of the console to 'printing' the output as text in the guide.

Let me know if you need help or some pointers.
@wooorm
Copy link
Member

wooorm commented Jul 1, 2019

@jasonqsong I think what @Murderlon makes a lot of sense for our use cases, but would like to express that I’m extremely grateful that you started work on this! 💪
@jasonqsong
Copy link
Author

jasonqsong commented Jul 1, 2019

The proposal looks good to me :) I'm not very familiar with angular or vue. I can only help the webpack part and the react part. Besides, I think the import, async/await of ES2016+ may need to be mentioned somewhere. And TypeScript needs to turn on "esModuleInterop".

But for most React/Angular user, npm install remark should be enough :) I came here only because it doesn't work in the development build on IE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murderlon Murderlon

@wooorm wooorm

Assignees
No one assigned
Labels
help wanted 🙏 📚 area/docs 🙆 status/confirmed 🦋 type/enhancement
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jasonqsong @wooorm @Murderlon
You can’t perform that action at this time.