★ wanayoo — archive 1999 https://github.com/unifiedjs/unified/pull/89Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the broken learn link #89

Closed
wants to merge 1 commit into from
Closed

Conversation

trebeljahr
Copy link

@trebeljahr trebeljahr commented Jun 9, 2020

I think the link to the learning page is broken at the moment because of the black lives matter page which does not have the [learn] URL of https://unifiedjs.com/learn so for the time being a link to the GitHub section or something similar could be added as a kind of fallback.

I think the link to the learning page is broken at the moment because of the black lives matter page which does not have the [learn] URL of https://unifiedjs.com/learn so for the time being a link to the GitHub section or something similar could be added.
Copy link
Member

@Murderlon Murderlon left a comment •

Thanks for catching this. I don’t think we’ll need this change as the site will probably be back soon. @wooorm is this a correct assumption as most sites don’t completely block the site for more than a couple of days? We could optionally add a banner like https://reactjs.org.

If we were to update the link, the phrasing should be updated. It correctly refers to the learn section being part of the website. (Which it is but not currently).

visit unifiedjs.com and peruse its Learn section

Lastly, the test fails because of an unused definition.

 1256:1-1256:38  warning  Found unused definition  no-unused-definitions  remark-lint

@wooorm
Copy link
Member

@wooorm wooorm commented Jun 11, 2020

Activism is annoying to the status quo; I believe directing traffic away from the website / that activism is counter productive.

Our website is useful but not essential. I propose waiting a bit longer before reverting, optionally with a banner, e.g., as long as Node’s homepage is different, too

@wooorm
Copy link
Member

@wooorm wooorm commented Jun 11, 2020

Going to close this, as this link won’t have to be changed. Open to discussing when and how to change the website somewhere else though!

Thanks @trebeljahr for working on a fix, and for understanding!

@wooorm wooorm closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants