★ wanayoo — archive 1999 https://github.com/tmux-python/tmuxp/pull/339Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for listing existing configurations #339

Closed
wants to merge 9 commits into from

Conversation

@anddam
Copy link
Contributor

@anddam anddam commented Feb 7, 2018

No description provided.

@anddam
Copy link
Contributor Author

@anddam anddam commented Feb 7, 2018

The lines echoing workspace configurations should likely go outside the try block since they do not depend on the scandir execution.

@anddam
Copy link
Contributor Author

@anddam anddam commented Feb 8, 2018

I moved the output part outside the try block and made the docstring slightly more readable.

@tony
Copy link
Member

@tony tony commented Mar 4, 2018

Sorry for the late response. (I already replied in the other issue)

Can this be rebased via git pull --rebase origin master and git push --force?

@tony
Copy link
Member

@tony tony commented Mar 5, 2018

Closing and reopening (trying to trigger travis build)

@tony tony closed this Mar 5, 2018
@tony tony reopened this Mar 5, 2018
@anddam
Copy link
Contributor Author

@anddam anddam commented Mar 5, 2018

Sure, but I need to sort out my own repo before that.

@codecov-io
Copy link

@codecov-io codecov-io commented Mar 6, 2018

Codecov Report

Merging #339 into master will decrease coverage by 1.3%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   75.67%   74.36%   -1.31%     
==========================================
  Files           5        5              
  Lines         777      792      +15     
  Branches      226      230       +4     
==========================================
+ Hits          588      589       +1     
- Misses        136      148      +12     
- Partials       53       55       +2
Impacted Files Coverage Δ
tmuxp/cli.py 55.65% <26.66%> (-1.4%) ⬇️
tmuxp/workspacebuilder.py 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b8e94...8f0fe04. Read the comment docs.

@anddam anddam force-pushed the anddam:add-list-feature branch from f993992 to e2986af Mar 8, 2018
@anddam
Copy link
Contributor Author

@anddam anddam commented Mar 8, 2018

I rebased on top of your master branch.

@anddam anddam closed this Jul 5, 2018
@anddam anddam deleted the anddam:add-list-feature branch Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.