★ wanayoo — archive 1999 https://github.com/pythongssapi/python-gssapi/pull/219Nouvelle recherche | Portail wanayoo
Skip to content

/ python-gssapi

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Drop dependency on python-should_be #219

Open
wants to merge 2 commits into
base: master
from
Open

tests: Drop dependency on python-should_be #219

wants to merge 2 commits into from

Conversation

@stanislavlevin
Copy link
Contributor

@stanislavlevin stanislavlevin commented Jul 10, 2020

Migrate should_be assertions to unittest(stdlib) ones.
This requires Python3.2+.

Fixes: #215
@frozencemetery
frozencemetery requested changes Jul 10, 2020
View changes
Copy link
Member

@frozencemetery frozencemetery left a comment

Awesome, thanks. Are you okay to address the flake errors? And can you add a commit to revert the changes in 274886c so that we actually test it on 3.8?

(Let me know if you're not up for doing that and I'll take care of it.)
@stanislavlevin
tests: Drop dependency on python-should_be
Verified
This commit was signed with a verified signature.
stanislavlevin Stanislav Levin
GPG key ID: ABABFE8D5D9A19E8 Learn about signing commits
300d3ff 
Migrate should_be assertions to unittest(stdlib) ones.
This requires Python3.2+.

Fixes: #215
Signed-off-by: Stanislav Levin <slev@altlinux.org>
@stanislavlevin stanislavlevin force-pushed the stanislavlevin:migrate_from_shouldbe branch from b0b8057 to 47c74c1 Jul 13, 2020
@stanislavlevin
Revert "[ci] Hold back Fedora version for should-be"
Verified
This commit was signed with a verified signature.
stanislavlevin Stanislav Levin
GPG key ID: ABABFE8D5D9A19E8 Learn about signing commits
Loading status checks…
1e7dee0 
This reverts commit 274886c
to run CI against Python3.8.

Signed-off-by: Stanislav Levin <slev@altlinux.org>
@stanislavlevin stanislavlevin force-pushed the stanislavlevin:migrate_from_shouldbe branch from 47c74c1 to 1e7dee0 Jul 13, 2020
@stanislavlevin
Copy link
Contributor Author

@stanislavlevin stanislavlevin commented Jul 13, 2020

This morning github experienced availability problems.
That's why I had to push commits without changes (to trigger CI).
@stanislavlevin
Copy link
Contributor Author

@stanislavlevin stanislavlevin commented Jul 13, 2020

Fails are related to MIT krb5 1.18.2:
#220
@frozencemetery frozencemetery mentioned this pull request Jul 15, 2020
Merged
@stanislavlevin stanislavlevin mentioned this pull request Jul 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozencemetery frozencemetery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Port away from should_be
2 participants
@stanislavlevin @frozencemetery
You can’t perform that action at this time.