★ wanayoo — archive 1999 https://github.com/python-rapidjson/python-rapidjson/issues/60Nouvelle recherche | Portail wanayoo
Skip to content

/ python-rapidjson

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the possibility to not bundle rapidjson with the package? #60

Closed
SylvainCorlay opened this issue Jan 23, 2017 · 7 comments
Closed

Enable the possibility to not bundle rapidjson with the package? #60

SylvainCorlay opened this issue Jan 23, 2017 · 7 comments

Comments

@SylvainCorlay
Copy link

@SylvainCorlay SylvainCorlay commented Jan 23, 2017

Both rapidjson and python-rapidjson have been bundled for conda-forge,

However, the latter makes use of the rapidjson submodule.

It would probably make sense for the setup.py to handle the case where an installation prefix for rapidjson is provided instead of a submodule.

For reference, such a setup.py has been done for pyzmq which can either bundle zeromq or not.
@SylvainCorlay SylvainCorlay mentioned this issue Jan 23, 2017
Closed
@lelit
Copy link
Contributor

@lelit lelit commented Jan 23, 2017

Can you give some more information on this? Is it just some kind of option so that you can build python-rapidjson using a different path where the compiler search for the rapidjson includes, or what?
@SylvainCorlay
Copy link
Author

@SylvainCorlay SylvainCorlay commented Jan 23, 2017

Yes exactly. For example, the pyzmq wheel from pypi bundles libzmq. The one from conda uses the libzmq from conda which is its own package.
lelit added a commit that referenced this issue Jan 26, 2017
@lelit
Add a “--rj-include-dir=” option to the setup script
c4df408 
This allows to use a local copy of the RapidJSON include files, without the
need of cloning its repository into the ./rapidjson submodule.

This fixes issue #60.
@lelit
Copy link
Contributor

@lelit lelit commented Jan 26, 2017

Sylvain, does this fulfill your needs?
@SylvainCorlay
Copy link
Author

@SylvainCorlay SylvainCorlay commented Jan 26, 2017

@lelit thanks! I will try this for the conda-forge recipe and get back to you.
@lelit
Copy link
Contributor

@lelit lelit commented Feb 17, 2017

Just curious, did that help?
@lelit
Copy link
Contributor

@lelit lelit commented Mar 2, 2017

The proposed change is included in version 0.0.9, please reopen the issue if that's not enough.
Thank you!
@lelit lelit closed this Mar 2, 2017
@SylvainCorlay
Copy link
Author

@SylvainCorlay SylvainCorlay commented Mar 2, 2017

THanks @lelit and sorry for the late reply. I am updating the conda recipe to 0.10.0 and testing the functionality.
lelit added a commit that referenced this issue Aug 2, 2018
@lelit
Check for --rj-include-dir earlier
Loading status checks…
d10ab02 
This targets issue #110, and fixups commit c4df408:
I'm quite surprised that this went unnoticed when I closed issue #60... sorry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@lelit @SylvainCorlay
You can’t perform that action at this time.