★ wanayoo — archive 1999 https://github.com/python-cmd2/cmd2/pull/1004Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed alias/macro list commands to include quoted redirectors and terminators #1004

Merged
merged 1 commit into from Oct 1, 2020

Conversation

@kmvanbrunt
Copy link
Member

@kmvanbrunt kmvanbrunt commented Sep 30, 2020

Since alias/macro list didn't include the quoted redirectors and terminators, startup scripts did not correctly recreate all aliases and macros.

@kmvanbrunt kmvanbrunt requested a review from anselor Sep 30, 2020
@kmvanbrunt kmvanbrunt requested review from kotfu and tleonhardt as code owners Sep 30, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 30, 2020

Codecov Report

Merging #1004 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
+ Coverage   97.86%   97.87%   +0.01%     
==========================================
  Files          22       22              
  Lines        4583     4613      +30     
==========================================
+ Hits         4485     4515      +30     
  Misses         98       98              
Impacted Files Coverage Δ
cmd2/cmd2.py 97.27% <100.00%> (+0.03%) ⬆️
cmd2/utils.py 97.88% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7b9e5...018c329. Read the comment docs.

@tleonhardt
Copy link
Member

@tleonhardt tleonhardt commented Sep 30, 2020

Something seems messed up with TravisCI reporting results to GitHub for us. But the tests are passing: https://travis-ci.org/github/python-cmd2/cmd2/builds/731691716

@kmvanbrunt kmvanbrunt force-pushed the redirected_aliases branch from 7f69609 to bd366a2 Oct 1, 2020
…acros were not being

restored when read from a startup script.
@kmvanbrunt kmvanbrunt force-pushed the redirected_aliases branch from bd366a2 to 018c329 Oct 1, 2020
@kmvanbrunt kmvanbrunt merged commit ad646aa into master Oct 1, 2020
1 of 8 checks passed
1 of 8 checks passed
Analyze (python)
Details
python-cmd2.cmd2 (Test Python35) Test Python35 failed
Details
python-cmd2.cmd2 (Test Python36) Test Python36 failed
Details
python-cmd2.cmd2 (Test Python37) Test Python37 failed
Details
python-cmd2.cmd2 (Test Python38) Test Python38 failed
Details
python-cmd2.cmd2
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@kmvanbrunt kmvanbrunt deleted the redirected_aliases branch Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.