★ wanayoo — archive 1999 https://github.com/poise/application_python/pull/82Nouvelle recherche | Portail wanayoo
Skip to content

/ application_python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ?nil when checking for integer. #82

Merged
merged 1 commit into from May 11, 2017
Merged

Use ?nil when checking for integer. #82

merged 1 commit into from May 11, 2017

Conversation

@maraca
Copy link
Contributor

maraca commented May 11, 2017

Fixes #81
@maraca
Use ?nil when checking for integer.
Loading status checks…
2b122c0 
Fixes #81
@coderanger
Copy link
Member

coderanger commented May 11, 2017

Lulz, copy pasta fail. Thanks!
@coderanger coderanger merged commit f8d9812 into poise:master May 11, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@maraca
Copy link
Contributor Author

maraca commented May 11, 2017

Thanks for the super prompt review! Would you mind bumping the minor version of the metadata so we can push a new release? Thanks!
@coderanger
Copy link
Member

coderanger commented May 11, 2017

I'll probably do it later tonight after the tests finish. As a workaround you can use the non-URL form for now.
@maraca
Copy link
Contributor Author

maraca commented May 11, 2017

Sure thing. Again, thanks for being so quick on this ;)
@codecov-io
Copy link

codecov-io commented May 11, 2017

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files          15       15           
  Lines         388      388           
=======================================
  Hits          355      355           
  Misses         33       33
Impacted Files Coverage Δ
lib/poise_application_python/resources/django.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443a480...2b122c0. Read the comment docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@maraca @coderanger @codecov-io
You can’t perform that action at this time.