★ wanayoo — archive 1999 https://github.com/nodejs/node-core-utils/pull/490Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactor and allow to fixup everythindg into first commit with --fixupAll #490

Merged
merged 2 commits into from Aug 27, 2020

Conversation

@lundibundi
Copy link
Member

@lundibundi lundibundi commented Aug 22, 2020

No description provided.

lundibundi added 2 commits Aug 22, 2020
@codecov
Copy link

@codecov codecov bot commented Aug 22, 2020 •

Codecov Report

Merging #490 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files          34       34           
  Lines        1696     1696           
=======================================
  Hits         1410     1410           
  Misses        286      286           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f66c27d...0f5f069. Read the comment docs.

@joyeecheung joyeecheung merged commit 4ad4a58 into nodejs:master Aug 27, 2020
9 of 10 checks passed
9 of 10 checks passed
commitlint
Details
Lint using ESLint
Details
Test on Node.js 10.x and ubuntu-latest
Details
Test on Node.js 10.x and macOS-latest
Details
Test on Node.js 12.x and ubuntu-latest
Details
Test on Node.js 12.x and macOS-latest
Details
Test on Node.js 14.x and ubuntu-latest
Details
Test on Node.js 14.x and macOS-latest Test on Node.js 14.x and macOS-latest
Details
codecov/patch Coverage not affected when comparing f66c27d...0f5f069
Details
codecov/project 83.13% (+0.00%) compared to f66c27d
Details
@lundibundi lundibundi deleted the lundibundi:allow-to-squash-all branch Aug 27, 2020
@lundibundi lundibundi mentioned this pull request Aug 29, 2020
4 of 4 tasks complete
@lundibundi lundibundi mentioned this pull request Sep 23, 2020
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.