★ wanayoo — archive 1999 https://github.com/nodejs/node-core-utils/pull/329Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak CI walk filter order #329

Closed
wants to merge 1 commit into from
Closed

Tweak CI walk filter order #329

wants to merge 1 commit into from

Conversation

@refack
Copy link
Member

@refack refack commented Mar 22, 2019

Moved more specific pattern higher up

@refack refack self-assigned this Mar 22, 2019
@@ -238,23 +236,25 @@ const FAILURE_FILTERS = [{
}, {
filter(ctx, text) {
const patterns = [{
pattern: /FATAL: .+/g,
context: { index: -1, contextBefore: 0, contextAfter: 5 }
pattern: /There is not enough space in the file system./g,

This comment has been minimized.

@joyeecheung

joyeecheung Mar 23, 2019
Member

The ones moved here are actually more specific? Can you split those instead?

This comment has been minimized.

@refack

refack Mar 23, 2019
Author Member

Yeah I wrote this patch on GitHub, hoping I hit it in one try ¯\(ツ)/¯
I need to dig into this locally a bit more...

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented May 30, 2020

Ping @refack

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 29, 2020

This PR is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Aug 29, 2020
@codebytere codebytere closed this Sep 2, 2020
@codebytere codebytere deleted the ci-walk-parse-order branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.