★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/41235Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable #41235

Merged
merged 1 commit into from Jan 6, 2022
Merged

build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable #41235

merged 1 commit into from Jan 6, 2022

Conversation

dsanders11
Copy link
Contributor

@dsanders11 dsanders11 commented Dec 19, 2021 •
edited by richardlau

Looks like VCBUILD_PYTHON_LOCATION went stale at some point, and isn't read anywhere (searching the repo shows this is the only usage).

Refs: #18621

@nodejs-github-bot nodejs-github-bot added install needs-ci tools windows labels Dec 19, 2021
@dsanders11 dsanders11 changed the title build,tools,win: Trim unused VCBUILD_PYTHON_LOCATION variable build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable Dec 19, 2021
RaisinTen
RaisinTen approved these changes Dec 19, 2021
View changes
Copy link
Member

@RaisinTen RaisinTen left a comment •
edited

Uses of VCBUILD_PYTHON_LOCATION were removed in #18621, LGTM.

@nodejs-github-bot

This comment has been hidden.

Sign in to view
@RaisinTen RaisinTen added the author ready label Dec 19, 2021
@github-actions github-actions bot mentioned this pull request Dec 20, 2021
Open
20 tasks
@github-actions github-actions bot mentioned this pull request Dec 21, 2021
Open
22 tasks
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@github-actions github-actions bot mentioned this pull request Dec 22, 2021
Open
21 tasks
@github-actions github-actions bot mentioned this pull request Dec 23, 2021
Open
19 tasks
@github-actions github-actions bot mentioned this pull request Dec 24, 2021
Open
18 tasks
@github-actions github-actions bot mentioned this pull request Dec 25, 2021
Open
19 tasks
@github-actions github-actions bot mentioned this pull request Dec 26, 2021
Open
19 tasks
@github-actions github-actions bot mentioned this pull request Dec 27, 2021
Open
17 tasks
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@github-actions github-actions bot mentioned this pull request Dec 28, 2021
Open
17 tasks
@github-actions github-actions bot mentioned this pull request Dec 29, 2021
Open
17 tasks
@github-actions github-actions bot mentioned this pull request Dec 30, 2021
Open
27 tasks
@github-actions github-actions bot mentioned this pull request Dec 31, 2021
Open
26 tasks
@github-actions github-actions bot mentioned this pull request Jan 1, 2022
Open
24 tasks
@github-actions github-actions bot mentioned this pull request Jan 2, 2022
Open
23 tasks
@github-actions github-actions bot mentioned this pull request Jan 3, 2022
Open
23 tasks
@github-actions github-actions bot mentioned this pull request Jan 4, 2022
Open
25 tasks
@github-actions github-actions bot mentioned this pull request Jan 5, 2022
Open
26 tasks
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Jan 5, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/41757/

@RaisinTen RaisinTen added the commit-queue label Jan 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue label Jan 6, 2022
@nodejs-github-bot nodejs-github-bot merged commit 79b21ee into nodejs:master Jan 6, 2022
52 checks passed
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Jan 6, 2022

Landed in 79b21ee

@dsanders11 dsanders11 deleted the patch-1 branch Jan 6, 2022
targos added a commit that referenced this issue Jan 14, 2022
@dsanders11 @targos
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
2233f31 
PR-URL: #41235
Refs: #18621
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
Linkgoron added a commit to Linkgoron/node that referenced this issue Jan 31, 2022
@dsanders11 @Linkgoron
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
ea01d8a 
PR-URL: nodejs#41235
Refs: nodejs#18621
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams added a commit that referenced this issue Feb 1, 2022
@dsanders11 @danielleadams
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
fc38d15 
PR-URL: #41235
Refs: #18621
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@richardlau richardlau

@RaisinTen RaisinTen

Assignees
No one assigned
Labels
author ready install needs-ci tools windows
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
5 participants
@dsanders11 @nodejs-github-bot @jasnell @richardlau @RaisinTen