★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/39963Nouvelle recherche | Portail wanayoo
Skip to content

/ node Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing changes to generateKeyPair(Sync) #39963

Closed
wants to merge 1 commit into from
Closed

doc: add missing changes to generateKeyPair(Sync) #39963

wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Aug 31, 2021

As a prerequisite for #39927 without any semverness, add missing "changes:" entries to the generateKeyPair(Sync) APIs.

Refs: #26774
Refs: #26960
@tniessen
doc: add missing changes to generateKeyPair(Sync)
c519462 
Refs: nodejs#26774
Refs: nodejs#26960
@tniessen tniessen requested a review from panva Aug 31, 2021
panva
panva approved these changes Aug 31, 2021
View changes
@github-actions
Copy link

@github-actions github-actions bot commented Aug 31, 2021

Fast-track has been requested by @tniessen. Please 👍 to approve.

aduh95
aduh95 approved these changes Aug 31, 2021
View changes
panva added a commit that referenced this issue Sep 1, 2021
@tniessen @panva
doc: add missing changes to generateKeyPair(Sync)
6155499 
Refs: #26774
Refs: #26960

PR-URL: #39963
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
Copy link
Member

@panva panva commented Sep 1, 2021

Landed in 6155499

@panva panva closed this Sep 1, 2021
targos added a commit that referenced this issue Sep 6, 2021
@tniessen @targos
doc: add missing changes to generateKeyPair(Sync)
80e686d 
Refs: #26774
Refs: #26960

PR-URL: #39963
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit that referenced this issue Sep 6, 2021
@tniessen @targos
doc: add missing changes to generateKeyPair(Sync)
fc01dd9 
Refs: #26774
Refs: #26960

PR-URL: #39963
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva

@aduh95 aduh95

Assignees
No one assigned
Labels
crypto doc fast-track
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@tniessen @panva @aduh95 @nodejs-github-bot