doc: change color contrast for accessibility #35047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before:
After:
|
tniessen
approved these changes
Sep 4, 2020
csabapalfi
approved these changes
Sep 4, 2020
XhmikosR
approved these changes
Sep 4, 2020
|
fast track? |
codebytere
approved these changes
Sep 4, 2020
DerekNonGeneric
approved these changes
Sep 4, 2020
|
Landed in f3b4846 |
richardlau
pushed a commit
that referenced
this issue
Sep 7, 2020
Change background color of Stability 1 banner. Previous color contrast of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes. PR-URL: #35047 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
richardlau
pushed a commit
that referenced
this issue
Sep 7, 2020
Change background color of Stability 1 banner. Previous color contrast of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes. PR-URL: #35047 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
addaleax
pushed a commit
that referenced
this issue
Sep 22, 2020
Change background color of Stability 1 banner. Previous color contrast of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes. PR-URL: #35047 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
addaleax
pushed a commit
that referenced
this issue
Sep 22, 2020
Change background color of Stability 1 banner. Previous color contrast of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes. PR-URL: #35047 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this issue
Jan 8, 2021
Change background color of Stability 1 banner. Previous color contrast of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes. PR-URL: nodejs#35047 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change background color of Stability 1 banner. Previous color contrast
of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes.
Checklist