doc: fix broken link to writableEnded in deprecations doc #34984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshithaKP
approved these changes
Aug 30, 2020
richardlau
reviewed
Aug 30, 2020
| @@ -2860,7 +2860,7 @@ The [`crypto.Certificate()` constructor][] is deprecated. Use | |||
| [`response.end()`]: http.html#http_response_end_data_encoding_callback | |||
| [`response.finished`]: #http_response_finished | |||
| [`response.writableFinished`]: #http_response_writablefinished | |||
| [`response.writableEnded`]: #http_response_writableended | |||
| [`response.writableEnded`]: http.html#http_response_writableended | |||
There was a problem hiding this comment.
Do the two lines above also need fixing?
There was a problem hiding this comment.
@richardlau There are 2 other PRs which are doing the same.
There was a problem hiding this comment.
@Trott isn't it better to use a single PR and commit?
There was a problem hiding this comment.
For easing backport-ability, I often try to keep doc changes isolated in separate commits. (Then if a commit doesn't apply cleanly, it's either trivial to fix or else shouldn't be backported at all.) But yeah, these probably at least should have gone in a single PR. I'll try to batch things up a bit better in the future.
lpinca
approved these changes
Aug 30, 2020
MrHeer
approved these changes
Aug 31, 2020
PR-URL: nodejs#34984 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 772a21c |
richardlau
pushed a commit
that referenced
this issue
Sep 1, 2020
PR-URL: #34984 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
pushed a commit
that referenced
this issue
Sep 3, 2020
PR-URL: #34984 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this issue
Sep 22, 2020
PR-URL: #34984 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this issue
Sep 22, 2020
PR-URL: #34984 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Checklist