doc: drop the --production flag for installing windows-build-tools #34979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't needed, and was probably copy-pasted from windows-build-tools' README.md, which has since been changed to drop the `--production` flag from the install instructions.
|
Review requested:
|
addaleax
approved these changes
Aug 29, 2020
richardlau
approved these changes
Aug 29, 2020
|
Fastest reviews I've ever had on anything, thanks folks! |
|
|
gengjiawen
approved these changes
Aug 30, 2020
rickyes
approved these changes
Aug 31, 2020
Commit Queue failed- Loading data for nodejs/node/pull/34979 ✔ Done loading data for nodejs/node/pull/34979 ----------------------------------- PR info ------------------------------------ Title doc: drop the --production flag for installing windows-build-tools (#34979) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch DeeDeeG:docs-no-production-flag-for-windows-build-tools -> nodejs:master Labels author ready, doc, fast-track, n-api Commits 1 - doc: drop the --production flag for installing windows-build-tools Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/34979 Reviewed-By: Anna Henningsen Reviewed-By: Richard Lau Reviewed-By: Jiawen Geng Reviewed-By: Ricky Zhou <0x19951125@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/34979 Reviewed-By: Anna Henningsen Reviewed-By: Richard Lau Reviewed-By: Jiawen Geng Reviewed-By: Ricky Zhou <0x19951125@gmail.com> -------------------------------------------------------------------------------- ✖ No CI runs detected ℹ This PR was created on Sat, 29 Aug 2020 22:12:20 GMT ✔ Approvals: 4 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/34979#pullrequestreview-478157809 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/34979#pullrequestreview-478157868 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/34979#pullrequestreview-478163623 ✔ - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/34979#pullrequestreview-478645360 ℹ This PR is being fast-tracked -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
rickyes
pushed a commit
that referenced
this issue
Aug 31, 2020
This isn't needed, and was probably copy-pasted from windows-build-tools' README.md, which has since been changed to drop the `--production` flag from the install instructions. PR-URL: #34979 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
richardlau
pushed a commit
that referenced
this issue
Sep 2, 2020
This isn't needed, and was probably copy-pasted from windows-build-tools' README.md, which has since been changed to drop the `--production` flag from the install instructions. PR-URL: #34979 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
richardlau
pushed a commit
that referenced
this issue
Sep 3, 2020
This isn't needed, and was probably copy-pasted from windows-build-tools' README.md, which has since been changed to drop the `--production` flag from the install instructions. PR-URL: #34979 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax
pushed a commit
that referenced
this issue
Sep 22, 2020
This isn't needed, and was probably copy-pasted from windows-build-tools' README.md, which has since been changed to drop the `--production` flag from the install instructions. PR-URL: #34979 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax
pushed a commit
that referenced
this issue
Sep 22, 2020
This isn't needed, and was probably copy-pasted from windows-build-tools' README.md, which has since been changed to drop the `--production` flag from the install instructions. PR-URL: #34979 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Drop
--productionfrom the install instructions forwindows-build-tools. The--productionflag isn't needed here, as "not installing devDependencies" is already implied whennpm installing a module by name.(This was probably copy-pasted a while ago from
windows-build-tools'README.md, which has since been updated to drop the--productionflag from its install instructions: felixrieseberg/windows-build-tools@4420dc8)Checklist