★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/32541Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove non required console.log #32541

Closed
wants to merge 1 commit into from
Closed

test: remove non required console.log #32541

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

@juanarbol juanarbol commented Mar 29, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Mar 29, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 29, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30164/

cjihrig
cjihrig approved these changes Mar 29, 2020
View changes
Copy link
Contributor

@cjihrig cjihrig left a comment

LGTM. Alternatively, you could change the console.log() to util.debuglog().

@jasnell
Copy link
Member

@jasnell jasnell commented Mar 29, 2020

LGTM. Alternatively, you could change the console.log() to util.debuglog().

If you wanted to do this, include const debug = require('util').debuglog('test') at the top of the file then call debug('...')

@juanarbol juanarbol mentioned this pull request Mar 29, 2020
Closed
3 tasks
@juanarbol
Copy link
Member Author

@juanarbol juanarbol commented Mar 29, 2020

If you wanted to do this, include const debug = require('util').debuglog('test') at the top of the file then call debug('...')

Something like this?

I think this test does not require logging very much.

Trott
Trott approved these changes Mar 30, 2020
View changes
Copy link
Member

@Trott Trott left a comment

LGTM.

Commit message suggestion:

test: remove unnecessary console.log() calls

@juanarbol juanarbol force-pushed the juanarbol/remove-console-log branch from 9550ead to c21e9b9 Compare Mar 30, 2020
@juanarbol
Copy link
Member Author

@juanarbol juanarbol commented Mar 30, 2020

LGTM.

Commit message suggestion:

test: remove unnecessary console.log() calls

Commit reword is done! Thank you!

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 1, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30304/

@ZYSzys ZYSzys added the author ready label Apr 1, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 2, 2020 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/30374/ ✔️

addaleax pushed a commit that referenced this issue Apr 2, 2020
@juanarbol @addaleax
test: replace console.log() with debuglog()
579e6b9 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@addaleax
Copy link
Member

@addaleax addaleax commented Apr 2, 2020

Landed in 9a914ff

addaleax pushed a commit that referenced this issue Apr 2, 2020
@juanarbol @addaleax
test: remove unnecessary console.log() calls
9a914ff 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax addaleax closed this Apr 2, 2020
BethGriggs pushed a commit that referenced this issue Apr 7, 2020
@juanarbol @BethGriggs
test: replace console.log() with debuglog()
b2339c8 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BethGriggs pushed a commit that referenced this issue Apr 7, 2020
@juanarbol @BethGriggs
test: remove unnecessary console.log() calls
9d6adf3 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Apr 12, 2020
@juanarbol @targos
test: replace console.log() with debuglog()
8f0c106 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this issue Apr 12, 2020
@juanarbol @targos
test: remove unnecessary console.log() calls
30505d7 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this issue Apr 22, 2020
@juanarbol @targos
test: replace console.log() with debuglog()
30d21fb 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this issue Apr 22, 2020
@juanarbol @targos
test: remove unnecessary console.log() calls
4165312 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
@juanarbol juanarbol deleted the juanarbol/remove-console-log branch Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@Trott Trott

@cjihrig cjihrig

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@juanarbol @nodejs-github-bot @jasnell @addaleax @Trott @cjihrig @ZYSzys