★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/32519Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document that server.address() can return null #32519

Closed
wants to merge 0 commits into from

Conversation

Copy link
Member

@watson watson commented Mar 27, 2020

Checklist

@nodejs-github-bot nodejs-github-bot added doc net labels Mar 27, 2020
doc/api/net.md Outdated Show resolved Hide resolved
doc/api/net.md Outdated Show resolved Hide resolved
Copy link
Member

@addaleax addaleax left a comment

LGTM with @jasnell’s suggestion applied

Trott
Trott approved these changes Apr 5, 2020
@Trott Trott added the author ready label Apr 5, 2020
@Trott
Copy link
Member

@Trott Trott commented Apr 5, 2020

Landed in 04b7184

Trott pushed a commit to watson/node that referenced this issue Apr 5, 2020
PR-URL: nodejs#32519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott closed this Apr 5, 2020
BethGriggs pushed a commit that referenced this issue Apr 7, 2020
PR-URL: #32519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Apr 12, 2020
PR-URL: #32519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Apr 22, 2020
PR-URL: #32519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready doc net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants