★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/32508Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix check error name on error instance #32508

Closed

Conversation

Copy link
Member

@Himself65 Himself65 commented Mar 26, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test label Mar 26, 2020
Copy link
Member

@lpinca lpinca left a comment

LGTM with the lint error fixed.

@Himself65 Himself65 force-pushed the 20200327-refactor-error-name branch from 498e215 to aaa8408 Compare Mar 27, 2020
@Himself65
Copy link
Member Author

@Himself65 Himself65 commented Mar 27, 2020

fixed

@addaleax addaleax added the author ready label Apr 2, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 2, 2020

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 5, 2020

jasnell pushed a commit that referenced this issue Apr 7, 2020
PR-URL: #32508
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

@jasnell jasnell commented Apr 7, 2020

Landed in 6ed912d

@jasnell jasnell closed this Apr 7, 2020
BethGriggs pushed a commit that referenced this issue Apr 7, 2020
PR-URL: #32508
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Apr 12, 2020
PR-URL: #32508
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Apr 22, 2020
PR-URL: #32508
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants