★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/32481Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed unused error code #32481

Closed

Conversation

Copy link
Member

@yashLadha yashLadha commented Mar 25, 2020

Removed an unused error code, as the value is not read anywhere else.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the worker label Mar 25, 2020
Copy link
Member

@Himself65 Himself65 left a comment

commit message should be lib: removed unused error code

@yashLadha yashLadha force-pushed the chore/remove_unused_import branch from b95464e to 0d07b6f Compare Mar 25, 2020
@addaleax addaleax added the author ready label Mar 29, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 29, 2020

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 29, 2020

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 30, 2020

@addaleax
Copy link
Member

@addaleax addaleax commented Mar 30, 2020

Landed in a5e81e7

@addaleax addaleax closed this Mar 30, 2020
addaleax pushed a commit that referenced this issue Mar 30, 2020
PR-URL: #32481
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@yashLadha yashLadha deleted the chore/remove_unused_import branch Mar 30, 2020
addaleax pushed a commit that referenced this issue Mar 30, 2020
PR-URL: #32481
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos added backport-blocked-v12.x and removed author ready backport-blocked-v12.x labels Apr 22, 2020
targos pushed a commit to targos/node that referenced this issue Apr 25, 2020
PR-URL: nodejs#32481
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Apr 28, 2020
PR-URL: #32481
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants