★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/32387Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: remove *.pyc files from deps/npm #32387

Merged
merged 1 commit into from Mar 20, 2020
Merged

deps: remove *.pyc files from deps/npm #32387

merged 1 commit into from Mar 20, 2020

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Mar 20, 2020

These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

Refs: #32368
Refs: npm/cli#1037

I'm proposing fast-tracking this because it's annoying.
@bnoordhuis bnoordhuis mentioned this pull request Mar 20, 2020
Closed
mcollina
mcollina approved these changes Mar 20, 2020
View changes
Copy link
Member

@mcollina mcollina left a comment

lgtm

@mcollina
Copy link
Member

@mcollina mcollina commented Mar 20, 2020

+1 to fast-track

targos
targos approved these changes Mar 20, 2020
View changes
@bnoordhuis
deps: remove *.pyc files from deps/npm
fbecc07 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: nodejs#32387
Refs: nodejs#32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@bnoordhuis bnoordhuis merged commit fbecc07 into nodejs:master Mar 20, 2020
@bnoordhuis bnoordhuis deleted the rm-npm-pyc branch Mar 20, 2020
@bnoordhuis
Copy link
Member Author

@bnoordhuis bnoordhuis commented Mar 20, 2020

Landed in fbecc07.

BethGriggs pushed a commit that referenced this issue Mar 23, 2020
@bnoordhuis @BethGriggs
deps: remove *.pyc files from deps/npm
bf26c44 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins added a commit that referenced this issue Mar 24, 2020
@bnoordhuis @MylesBorins
deps: remove *.pyc files from deps/npm
6112ae9 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
Merged
MylesBorins added a commit that referenced this issue Mar 24, 2020
@bnoordhuis @MylesBorins
deps: remove *.pyc files from deps/npm
8201704 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins added a commit to MylesBorins/node that referenced this issue Apr 1, 2020
@bnoordhuis @MylesBorins
deps: remove *.pyc files from deps/npm
dd4eb8b 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

PR-URL: nodejs#32387
Refs: nodejs#32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins added a commit that referenced this issue Apr 1, 2020
@bnoordhuis @MylesBorins
deps: remove *.pyc files from deps/npm
f55d071 
These seem to have accidentally slipped into the npm source tarball and
cause problems when contributors update their git checkout of node.

Backport-PR-URL: #32527
PR-URL: #32387
Refs: #32368
Refs: npm/cli#1037
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Apr 3, 2020
Merged
@BethGriggs BethGriggs mentioned this pull request Apr 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina

@targos targos

@cjihrig cjihrig

@richardlau richardlau

@BethGriggs BethGriggs

Assignees
No one assigned
Labels
fast-track npm
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@bnoordhuis @mcollina @targos @cjihrig @richardlau @BethGriggs @nodejs-github-bot